[meta-freescale] [PATCH 2/3] cm-fx6:kernel: add cm-fx6 kernel configuration files

[Daiane Angolini]

On Thu, Apr 9, 2015 at 4:05 AM, Valentin Raevsky
<valentin at compulab.co.il> wrote:
> Add cm-fx6 kernel configuration files.
> This is a fork of the linux-imx 3.10.17.ga with the CompuLab patches
> for cm-fx6 boards.
>
> Signed-off-by: Valentin Raevsky <valentin at compulab.co.il>
> ---
>  .../linux/linux-cm-fx6-3.10.17/cm_fx6_defconfig    | 3910 +++++++++++++
>  .../linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch | 5782 ++++++++++++++++++++
>  .../linux/linux-cm-fx6-3.10.17/defconfig           |    1 +
>  recipes-kernel/linux/linux-cm-fx6_3.10.17.bb       |   20 +
>  4 files changed, 9713 insertions(+)
>  create mode 100644 recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_defconfig

Have you used savedefconfig option to create the defconfig used here?
Can you, please, double check?

>  create mode 100644 recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch
>  create mode 120000 recipes-kernel/linux/linux-cm-fx6-3.10.17/defconfig

Why do you have 2 defconfig files? Can you, please, double check?

>  create mode 100644 recipes-kernel/linux/linux-cm-fx6_3.10.17.bb
>
> diff --git a/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_defconfig b/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_defconfig
> new file mode 100644
> index 0000000..b387969
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_defconfig
> @@ -0,0 +1,3910 @@
> +#
> +# Automatically generated file; DO NOT EDIT.
> +# Linux/arm 3.10.17 Kernel Configuration
> +#

I'm dropping defconfig as I'm not going to review it.

(...)

> diff --git a/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch b/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch
> new file mode 100644
> index 0000000..a78f1d2
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch

Where is the header for this patch? Could you, please add a proper
commit header in this patch? Like subject, commit log, authorship,
this kind of thing...


> diff --git a/recipes-kernel/linux/linux-cm-fx6_3.10.17.bb b/recipes-kernel/linux/linux-cm-fx6_3.10.17.bb
> new file mode 100644
> index 0000000..2b96b94
> --- /dev/null
> +++ b/recipes-kernel/linux/linux-cm-fx6_3.10.17.bb
> @@ -0,0 +1,20 @@

Please, remember to add Copyright information

> +require recipes-kernel/linux/linux-imx.inc
> +require recipes-kernel/linux/linux-dtb.inc
> +
> +SUMMARY = "CompuLab 3.10.17 kernel"
> +DESCRIPTION = "Linux kernel for CompuLab cm-fx6 boards \
> +       with full support for the i.MX6 features."

Please, elaborate DESCRIPTION here. What would mean "full support for
i.MX6 features" if even the kernel from Freescale does not guarrantee
"full support"?

There are some examples in [1] you may follow


[1] http://freescale.github.io/doc/release-notes/1.7/index.html#linux-kernel

> +
> +DEPENDS += "lzop-native bc-native"
> +
> +# back to -1.0.0_ga branch for all patch release
> +SRCBRANCH = "imx_3.10.17_1.0.0_ga"
> +SRCREV = "33597e348b2d60dd5c71890ef7b7d3d3fd6e4e97"
> +LOCALVERSION = "-1.0.2_ga_cl"

Local vertion is the tag used in this table [2], please, choose this
wisely. (I am only giving you a chance to change it, if you like the
current one, I'm fine with this as well)

[2] http://freescale.github.io/doc/release-notes/1.7/index.html#default-linux-providers

> +
> +SRC_URI += "file://cm_fx6_kernel.patch \
> +            file://cm_fx6_defconfig \
> +"
> +
> +COMPATIBLE_MACHINE = "(mx6)"
> +COMPATIBLE_MACHINE = "(cm-fx6|sbc-fx6|sbc-fx6m)"

I'm confused here. I think you forgot to remove one line.


Regards,
Daiane
> --
> 1.7.9.5
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale