[meta-freescale] [PATCH 2/3] cm-fx6:kernel: add cm-fx6 kernel configuration files

[Otavio Salvador]

Hello Valentin,

Daiane comments were very accurate, I am adding some more comments on
top of her ones...

On Thu, Apr 9, 2015 at 8:58 AM, Daiane Angolini <daiane.list at gmail.com> wrote:
> On Thu, Apr 9, 2015 at 4:05 AM, Valentin Raevsky
> <valentin at compulab.co.il> wrote:
>> Add cm-fx6 kernel configuration files.
>> This is a fork of the linux-imx 3.10.17.ga with the CompuLab patches
>> for cm-fx6 boards.
>>
>> Signed-off-by: Valentin Raevsky <valentin at compulab.co.il>
...
>> diff --git a/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch b/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch
>> new file mode 100644
>> index 0000000..a78f1d2
>> --- /dev/null
>> +++ b/recipes-kernel/linux/linux-cm-fx6-3.10.17/cm_fx6_kernel.patch
>
> Where is the header for this patch? Could you, please add a proper
> commit header in this patch? Like subject, commit log, authorship,
> this kind of thing...

It seems you are applying a patch on top of the Freescale original
kernel. I believe it would be easier for you if you had a Git tree
with it applied (and preferable with useful git history).

CompuLab seems to have a github tree[1] so you can use it as reference
and also you can base on Boundary Devices[2] Git tree and their
recipe[3] in meta-fsl-arm-extra.

1. https://github.com/compulab/cm-fx6-kernel
2. https://github.com/boundarydevices/linux-imx6/tree/boundary-imx_3.10.53_1.1.1_ga
3. https://github.com/Freescale/meta-fsl-arm-extra/blob/master/recipes-kernel/linux/linux-boundary_3.10.53.bb

>> diff --git a/recipes-kernel/linux/linux-cm-fx6_3.10.17.bb b/recipes-kernel/linux/linux-cm-fx6_3.10.17.bb
...
>> +COMPATIBLE_MACHINE = "(mx6)"
>> +COMPATIBLE_MACHINE = "(cm-fx6|sbc-fx6|sbc-fx6m)"
...

Please restrict this to the cm-fx6 board as this is the one being
added now. When others are send this can be extended.

A more general rework necessary is the update to 3.10.53. This is
required as current GPU drivers are incompatible with 3.10.17-based
kernel.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750