[yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

Alexander Kanavin alexander.kanavin at linux.intel.com
Fri Dec 8 06:07:45 PST 2017


On 12/08/2017 03:51 AM, Robert Yang wrote:

>> I'm not sure about this one. Commits shouldn't be created 
>> automatically on a person's behalf and then also signed-off - I'd say 
>> you need to first look at them.
> 
> IMHO, Auh is a helper, when user run:
> $ auh less
> 
> It helps create commits, should be the same as user run "git commit", 
> and the
> user should responsible for it. Or how about add a -S option:
> 
> -S, --SOB    Use git user as the author and add SOB.

Yeah, as long as maintainers don't send those raw commits straight to 
mailing list, it's okay. It's rare that such an auto-created commit 
doesn't need further work (e.g. to explain changes in patches or 
license, or other adjustments).

Alex



More information about the yocto mailing list