[yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

Robert Yang liezhi.yang at windriver.com
Thu Dec 7 17:51:39 PST 2017


Hello,

On 12/07/2017 09:02 PM, Alexander Kanavin wrote:
> On 12/07/2017 09:37 AM, Robert Yang wrote:
>> E.g.,:
>> $ upgradehelper.py less
>>
>> commit d9b551438037e105eebabbbcb2da6d8b8cae7504
>> Author: Robert Yang <liezhi.yang at windriver.com>
>> Date:   Wed Dec 6 16:38:55 2017 +0800
>>
>>      less: upgrade to 529
>>
>>      Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> 
> I'm not sure about this one. Commits shouldn't be created automatically on a 
> person's behalf and then also signed-off - I'd say you need to first look at them.

IMHO, Auh is a helper, when user run:
$ auh less

It helps create commits, should be the same as user run "git commit", and the
user should responsible for it. Or how about add a -S option:

-S, --SOB	Use git user as the author and add SOB.

// Robert

> 
> Alex
> 



More information about the yocto mailing list