[yocto] [PATCH 04/10][AUH] buildhistory.py: Don't modify BB_ENV_EXTRAWHITE before init.

[Aníbal Limón]

On 11/10/2015 02:54 AM, Paul Eggleton wrote:
> On Monday 09 November 2015 16:01:35 Aníbal Limón wrote:
>> Move code for add BUILDHISTORY_DIR to __init__ method because
>> it fails when import in early step.
>>
>> Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
>> ---
>>  buildhistory.py | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/buildhistory.py b/buildhistory.py
>> index 1732f23..6eca6e1 100644
>> --- a/buildhistory.py
>> +++ b/buildhistory.py
>> @@ -30,11 +30,10 @@ from errors import *
>>  from bitbake import *
>>  from git import Git
>>
>> -os.environ['BB_ENV_EXTRAWHITE'] = os.environ['BB_ENV_EXTRAWHITE'] + \
>> -                                    " BUILDHISTORY_DIR"
>> -
>>  class BuildHistory(object):
>>      def __init__(self, bb, pn, workdir):
>> +        os.environ['BB_ENV_EXTRAWHITE'] = os.environ['BB_ENV_EXTRAWHITE'] +
>> \ +                                    " BUILDHISTORY_DIR"
>>          self.bb = bb
>>          self.pn = pn
>>          self.workdir = workdir
> 
> I'm not particularly happy with setting this through the environment. Leaving 
> that aside though, rather than putting it at the top of the constructor can 
> you please put this just before the line where we actually set 
> BUILDHISTORY_DIR in the environment?

I know that you aren't happy with this setting in the environment but
now is the only way to have a organized output (per recipe) of AUH as
you can see in the Status email i sent.

I'll change the code to be together this set of BUILDHISTORY_DIR.


> 
> Cheers,
> Paul
>