[yocto] [PATCH 04/10][AUH] buildhistory.py: Don't modify BB_ENV_EXTRAWHITE before init.

[Paul Eggleton]

On Monday 09 November 2015 16:01:35 Aníbal Limón wrote:
> Move code for add BUILDHISTORY_DIR to __init__ method because
> it fails when import in early step.
> 
> Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
> ---
>  buildhistory.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/buildhistory.py b/buildhistory.py
> index 1732f23..6eca6e1 100644
> --- a/buildhistory.py
> +++ b/buildhistory.py
> @@ -30,11 +30,10 @@ from errors import *
>  from bitbake import *
>  from git import Git
> 
> -os.environ['BB_ENV_EXTRAWHITE'] = os.environ['BB_ENV_EXTRAWHITE'] + \
> -                                    " BUILDHISTORY_DIR"
> -
>  class BuildHistory(object):
>      def __init__(self, bb, pn, workdir):
> +        os.environ['BB_ENV_EXTRAWHITE'] = os.environ['BB_ENV_EXTRAWHITE'] +
> \ +                                    " BUILDHISTORY_DIR"
>          self.bb = bb
>          self.pn = pn
>          self.workdir = workdir

I'm not particularly happy with setting this through the environment. Leaving 
that aside though, rather than putting it at the top of the constructor can 
you please put this just before the line where we actually set 
BUILDHISTORY_DIR in the environment?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre