[yocto] should layers define BB_DANGLINGAPPENDS_WARNONLY ?= "1"?

[Paul Eggleton]

Hi Robert,

On Monday 02 November 2015 12:54:33 Robert P. J. Day wrote:
>   perusing the meta-musl layer, and noticed in layer.conf the line:
> 
> BB_DANGLINGAPPENDS_WARNONLY ?= "1"
> 
> i thought this was a bit odd since (at least to me) it seems like the
> sort of thing a *developer* might set in their local.conf to
> temporarily deal with a dangling .bbappend file -- it never occurred
> to me that it would be appropriate for a layer to define that value
> itself as an inherent part of its own ... layerness.
> 
>   a quick grep of the couple dozen layers i have checked out revealed
> two layers that do that:
> 
> ./meta-musl/conf/layer.conf:BB_DANGLINGAPPENDS_WARNONLY ?= "1"
> ./meta-yocto-kernel-extras/meta-kernel-dev/conf/layer.conf:BB_DANGLINGAPPEND
> S_WARNONLY ?= "true"
> 
>   i'm curious what others think of this approach.

I'd say no, they shouldn't really. As a user of the layer you might not 
realise that it's making this change to your configuration.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre