[yocto] [PATCH 1/1] Enable iSCSI configs.

[Alexandru Vaduva]

Thanks Josep,

I kind of agree with your opinion here.
The patch does seem to add a target support that it is not mandatory for CGL and together with it some pretty specific configurations that might need extra comments added before the patch would be merged upstream :D


Alex V.

-----Original Message-----
From: Josep Puigdemont [mailto:josep.puigdemont at enea.com] 
Sent: Friday, August 28, 2015 2:49 PM
To: Alexandru Vaduva
Cc: yocto at yoctoproject.org
Subject: Re: [yocto] [PATCH 1/1] Enable iSCSI configs.

On Thu, Aug 27, 2015 at 05:34:31PM +0200, Alexandru.Vaduva wrote:
> From: Siva Borra <siva.borra at enea.com>
> 
> Enable iSCSI target and supported devices.
> 
> Signed-off-by: Siva Borra <siva.borra at enea.com>
> ---
>  .../recipes-kernel/linux/files/cfg/00023-open-scsi.cfg         | 10 +++++++++-

Not that it is specific to this patch but, why are all configuration fragments prefixed with a serial number?

>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git 
> a/meta-cgl-common/recipes-kernel/linux/files/cfg/00023-open-scsi.cfg 
> b/meta-cgl-common/recipes-kernel/linux/files/cfg/00023-open-scsi.cfg
> index e5075cb..90d5b3f 100644
> --- 
> a/meta-cgl-common/recipes-kernel/linux/files/cfg/00023-open-scsi.cfg
> +++ b/meta-cgl-common/recipes-kernel/linux/files/cfg/00023-open-scsi.c
> +++ fg
> @@ -1,4 +1,12 @@
>  CONFIG_SCSI_ISCSI_ATTRS=y
>  CONFIG_ISCSI_TCP=y
>  CONFIG_ISCSI_BOOT_SYSFS=y
> -
> +CONFIG_ISCSI_TARGET=y
> +CONFIG_TARGET_CORE=y
> +CONFIG_BE2ISCSI=y
> +CONFIG_CNIC=y
> +CONFIG_QLCNIC=y
> +CONFIG_SCSI_QLA_ISCSI=y
> +CONFIG_SCSI_CXGB4_ISCSI=y
> +CONFIG_SCSI_BNX2_ISCSI=y
> +CONFIG_SCSI_CXGB3_ISCSI=y

Are the device drivers actually required? If so, would it be possible to have them built as modules instead? I imagine not all users would want to have these drivers built in the kernel by default.

/Josep