[yocto] Issue with init scripts start-stop-daemon and use of set -e ?

[Alex J Lennon]

Hi,

I've been trying to track down an issue I was seeing with ofono not
restarting on a fido image and have encountered what seems to be an
issue related to the sys v init script.

Sometimes when we make a call as follows the ofono daemon isn't started
correctly

/etc/init.d/ofono restart

It seems there's a "set -e" in there to cause the script to exit if a
command returns a non-zero.

When the do_stop() function is called from restart if the daemon isn't
already running busybox will return non-zero which causes the script to
drop out and the do_start() method is never called.

(I have yet to determine why the ofono daemon might not be running
already when we make the call but that's a separate problem...)

Given the expected behaviour of calling restart on a service is to start
it even if it was not running then perhaps the "set -e" needs to be
removed or || true added ?

This seems relevant to ofono in master, and some quick grepping of
init.d shows other scripts are similar.

Can anybody comment?

Thanks,

Alex