[meta-xilinx] confused about linux-zynqmp-mainline_3.19.bb

[Nathan Rossi]

> -----Original Message-----
> From: meta-xilinx-bounces at yoctoproject.org [mailto:meta-xilinx-
> bounces at yoctoproject.org] On Behalf Of Robert P. J. Day
> Sent: Thursday, 5 March 2015 5:21 AM
> To: meta-xilinx at yoctoproject.org
> Subject: [meta-xilinx] confused about linux-zynqmp-mainline_3.19.bb
> 
> 
>  i'm poking around the meta-xilinx YP layer and am a tad confused
> about a couple kernel recipes. first, there's
> linux-zynqmp-mainline_3.19.bb, which opens with:
> 
> # Kernel version and SRCREV correspond to: xlnx_3.14 branch
> LINUX_VERSION = "3.19"
> KBRANCH ?= "master"
> SRCREV ?= "bfa76d49576599a4b9f9b7a71f23d73d6dcff735"
> 
> include linux-xlnx.inc
> 
>   so my first observation is that that comment doesn't seem right
> since it talks about the "xlnx_3.14" branch, but LINUX_VERSION is
> clearly being set to "3.19" and KBRANCH is set to "master".

You caught me, I copied the linux-xlnx_3.14 recipe :). That comment is in-accurate, and you are correct in picking up that it refers to 3.19. This recipe is actually just mainline v3.19 + some zynqmp patches that were submitted to the upstream kernel on the 23rd. I will fix up the comment so it is clear.

> 
>   however, immediately next, we have:
> 
> include linux-xlnx.inc
> 
> which then overrides some values, and sets SRC_URI to xilinx's github
> repo:
> 
> # Sources
> KBRANCH ?= "master"
> FILESEXTRAPATHS_prepend := "${THISDIR}/linux-xlnx:"
> SRC_URI = " \
> 
> git://github.com/Xilinx/linux-xlnx.git;protocol=https;branch=${KBRANCH} \
>                 file://xilinx-base;type=kmeta;destsuffix=xilinx-base \
>                 "
> 
> but, weirdly, once that file is included, things pick up again back in
> linux-zynqmp-mainline_3.19.bb, which reassigns SRC_URI:
> 
> FILESEXTRAPATHS_prepend := "${THISDIR}/linux-zynqmp-mainline:"
> SRC_URI = " \
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol=
> https;branch=${KBRANCH} \
> ... snip ...
> 
>   this is just confusing ... is there a reason it's being done this
> way?

Quickness of getting it going. I put together the recipes for these components relatively quickly, as I knew they would be short lived recipes and serve mainly as a day one release sort of thing. All of the patches are intended on going upstream, and once that has been achieved the goal is to remove these "zynqmp-mainline" recipes as oe-core/linux-yocto picks up the newer releases.

For this specific case it was easiest to just use the linux-xlnx recipe include, and override the source uri and srcrev. So that the build flow matched that of the linux-xlnx kernels. There are some undesirable changes that come from including it, but nothing that is particularly important from a functional build use case.

On a side note: Thanks for the patch fixing up the linux-xlnx-dev comment, I have applied that.

Regards,
Nathan

> 
> rday
> 
> --
> 
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                         http://crashcourse.ca
> 
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================
> --
> _______________________________________________
> meta-xilinx mailing list
> meta-xilinx at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-xilinx