[meta-intel] [PATCH 1/3] ace: add recipe for 6.5.3 version

[Usyskin, Alexander]

Thanks for thoughtful review!

> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton at intel.com]
> Sent: Monday, June 17, 2019 11:39
> To: Usyskin, Alexander <alexander.usyskin at intel.com>
> Cc: meta-intel <meta-intel at yoctoproject.org>; Winkler, Tomas
> <tomas.winkler at intel.com>
> Subject: Re: [meta-intel] [PATCH 1/3] ace: add recipe for 6.5.3 version
> 
> On Mon, 17 Jun 2019 at 08:04, Alexander Usyskin
> <alexander.usyskin at intel.com> wrote:
> > +DESCRIPTION = "C++ network programming framework that implements
> many core \
> > +patterns for concurrent communication software"
> > +LICENSE = "ACE-TAO-CIAO"
> 
> Can't see this license file anywhere.
> 
My fault, file is in custom-licenses and I've missed it in patch, will add in the next iteration.

> > +DEPENDS += "openssl gperf-native glibc"
> 
> No need to depend on glibc.
> 
Ok

> > +export ACE_ROOT="${WORKDIR}/ACE_wrappers"
> > +export LD_LIBRARY_PATH="${ACE_ROOT}/lib:$LD_LIBRARY_PATH"
> 
> Why do you export there here and again inside all of the do_*_prepends()?
> 
ACE requires ACE_ROOT at every part of build and I've had problems without this.
Will try to remove, and see if it will work.

> > +do_install_append() {
> > +    for i in $(find ${D} -name "*.pc") ; do
> > +        sed -i -e s:${D}::g \
> > +               -e s:/${TARGET_SYS}::g \
> > +                  $i
> > +    done
> > +}
> > +
> > +do_install() {
> > +    export ACE_ROOT="${S}"
> > +    export LD_LIBRARY_PATH="${ACE_ROOT}/lib:$LD_LIBRARY_PATH"
> > +    export D="${D}"
> > +    oe_runmake install
> > +}
> > +
> > +do_install_append () {
> > +    rm -r ${D}/usr/share/
> > +}
> 
> If you're writing your own do_install, don't also write two appends for it.
> 
Oops, will merge.

> > +FILES_${PN} += "${libdir}/pkgconfig/*"
> 
> These go in PN-dev, as they should be by default.
> 
I've had problems in LMS build with these files in PN-dev - LMS fail to pick up the library.
I'll give a try once more without this line.

The package was built for thud initially, don't know it there the build rules are different.

> Ross