[meta-intel] [PATCH 1/3] ace: add recipe for 6.5.3 version

[Burton, Ross]

On Mon, 17 Jun 2019 at 08:04, Alexander Usyskin
<alexander.usyskin at intel.com> wrote:
> +DESCRIPTION = "C++ network programming framework that implements many core \
> +patterns for concurrent communication software"
> +LICENSE = "ACE-TAO-CIAO"

Can't see this license file anywhere.

> +DEPENDS += "openssl gperf-native glibc"

No need to depend on glibc.

> +export ACE_ROOT="${WORKDIR}/ACE_wrappers"
> +export LD_LIBRARY_PATH="${ACE_ROOT}/lib:$LD_LIBRARY_PATH"

Why do you export there here and again inside all of the do_*_prepends()?

> +do_install_append() {
> +    for i in $(find ${D} -name "*.pc") ; do
> +        sed -i -e s:${D}::g \
> +               -e s:/${TARGET_SYS}::g \
> +                  $i
> +    done
> +}
> +
> +do_install() {
> +    export ACE_ROOT="${S}"
> +    export LD_LIBRARY_PATH="${ACE_ROOT}/lib:$LD_LIBRARY_PATH"
> +    export D="${D}"
> +    oe_runmake install
> +}
> +
> +do_install_append () {
> +    rm -r ${D}/usr/share/
> +}

If you're writing your own do_install, don't also write two appends for it.

> +FILES_${PN} += "${libdir}/pkgconfig/*"

These go in PN-dev, as they should be by default.

Ross