[meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

[Belal, Awais]

Hi Cal,

>> Could one of you review my patch and maybe take a look at the configure
>> block as a whole?

I've provided comments against your patch. Regarding the review of do_configure I believe we can go through it once the current patches are merged.

BR,
Awais

________________________________________
From: Cal Sullivan <california.l.sullivan at intel.com>
Sent: Saturday, March 31, 2018 2:26 AM
To: Belal, Awais; Kevin Hao
Cc: meta-intel at yoctoproject.org
Subject: Re: [meta-intel] [meta-dpdk][PATCH 2/2] dpdk: merge recipe and include

Hi Awais, Kevin,

In testing I ran into some compilation problems:
https://pastebin.com/n8dhUmZT

I was able to fix it by disabling some options, but I don't know the
ramifications of these changes.
In working on this I noticed most of the sed commands in that
do_configure block could use a review, as some are trying to modify
options that no longer exist there, and others assume =n in the string
to replace.

Could one of you review my patch and maybe take a look at the configure
block as a whole?

Thanks,
Cal

On 03/29/2018 11:36 PM, Belal, Awais wrote:
> Do we know when this will be merged?
>
> BR,
> Awais