[meta-intel] [master & jethro][PATCH 1/2] meta-isg: openssl-qat: Add support for v0.4.9-009

[Gupta, Rahul KumarXX]

Hi Saul,

> On Wed, 2016-02-03 at 15:41 +0800, Rahul Kumar Gupta wrote:
> > This recipe adds the openssl-qat engine that accelerates some of the
> > libcrypto
> > algorithms via the Intel QAT implemented on Intel communication
> > chipsets.
> >
> > QAT sample patch v0.4.9-009 is based on async branch of openssl-
> > 1.0.1m.
> >
> > The recipe is for platforms like grantley and crystalforest
> > using the common BSP intel-corei7-64.
> >
> > Signed-off-by: Rahul Kumar Gupta <rahul.kumarxx.gupta at intel.com>
> > ---
> >  .../recipes-extended/openssl-qat/openssl-qat.inc   |  117 +
> >  ...sl_qat-add-openssl-async-specific-symbols.patch |  113 +
> >  ..._0.4.9-009-openssl_qat-add-version-script.patch | 4695
> > ++++++++++++++++++++
> >  ...qat-build-qat_mem-ko-against-yocto-kernel.patch |   62 +
> >  ...-environment-variables-to-have-precedence.patch |   59 +
> >  ...openssl_qat-install-engines-in-libdir-ssl.patch |   72 +
> >  .../openssl_qat-pass-oe_ldflags-to-linker.patch    |   40 +
> >  .../openssl_qat-remove-redundant-rpaths.patch      |   31 +
> >  .../openssl-qat/openssl-qat_0.4.9-009.bb           |   12 +
> >  9 files changed, 5201 insertions(+)
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat.inc
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat/openssl-qat_0.4.9-009-openssl_qat-add-openssl-async-
> > specific-symbols.patch
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat/openssl-qat_0.4.9-009-openssl_qat-add-version-
> > script.patch
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat/openssl_qat-build-qat_mem-ko-against-yocto-
> > kernel.patch
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat/openssl_qat-environment-variables-to-have-
> > precedence.patch
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat/openssl_qat-install-engines-in-libdir-ssl.patch
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat/openssl_qat-pass-oe_ldflags-to-linker.patch
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat/openssl_qat-remove-redundant-rpaths.patch
> >  create mode 100644 meta-isg/common/recipes-extended/openssl-
> > qat/openssl-qat_0.4.9-009.bb
> >
> > diff --git a/meta-isg/common/recipes-extended/openssl-qat/openssl-
> > qat.inc b/meta-isg/common/recipes-extended/openssl-qat/openssl-
> > qat.inc
> > new file mode 100644
> > index 0000000..ae661b7
> > --- /dev/null
> > +++ b/meta-isg/common/recipes-extended/openssl-qat/openssl-qat.inc
> > @@ -0,0 +1,117 @@
> > +SUMMARY = "libcrypto* (OpenSSL*) QAT_MEM Memory Management
> Module \
> > +for Intel Quick Assist Technology"
> > +DESCRIPTION = "This software adds an engine that accelerates some of
> > \
> > +the libcrypto algorithms via the Intel QuickAssist Technology \
> > +implemented on Intel Communications Chipset 89xx Series based
> > platforms."
> > +
> > +HOMEPAGE = "http://www.openssl.org/"
> > +SECTION = "libs/network"
> > +LICENSE = "openssl & GPLv2 & BSD"
> > +
> > +LIC_FILES_CHKSUM =
> > "file://${WORKDIR}/git/LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8
> \
> > +                    file://${COMMON_LICENSE_DIR}/GPL-
> > 2.0;md5=801f80980d171dd6425610833a22dbe6 \
> > +                    file://${COMMON_LICENSE_DIR}/BSD;md5=3775480a712
> > fc46a69647678acb234cb \
> > +                    "
> > +
> > +SRC_URI  = "https://01.org/sites/default/files/page/libcrypto_shim_$
> > {PV}_withdocumentation.zip;name=openssl_qat;subdir=openssl_qat-
> ${PV}
> > \
> > +            file://openssl_qat-environment-variables-to-have-
> > precedence.patch \
> > +            file://openssl_qat-pass-oe_ldflags-to-linker.patch \
> > +            file://openssl_qat-remove-redundant-rpaths.patch \
> > +            file://openssl_qat-build-qat_mem-ko-against-yocto-
> > kernel.patch \
> > +            file://openssl_qat-install-engines-in-libdir-ssl.patch \
> > +            "
> > +
> > +DEPENDS         += " qat16 zlib"
> > +RDEPENDS_${PN}  += " qat16 zlib"
> > +
> > +inherit pkgconfig module
> > +
> > +PACKAGES =+ "${PN}-misc"
> > +PARALLEL_MAKE = ""
> > +PARALLEL_MAKEINST = ""
> > +
> Why are you disabling parallel make?


Parallel make leads to the compilation error like 'undefined reference to 'XXXXXXX' . But I can able to  do parallel installation so I  have removed PARALLEL_MAKEINST="" in v2.

> 
> > +AR_append = " r"
> > +EXTRA_OECONF = " -no-ssl3"
> > +
> > +export ICP_ROOT = "${WORKDIR}/git"
> > +export ICP_BUILD_OUTPUT = "${STAGING_DIR_TARGET}"
> > +export OPENSSL_ROOT = "${ICP_ROOT}"
> > +export OPENSSL_PREFIX = "/usr/local"
> > +export AS = "${CC} -c"
> > +export OE_LDFLAGS="${LDFLAGS} -L${OPENSSL_PREFIX}{base_libdir}"
> > +export ICP_API_PATH = "${STAGING_DIR_TARGET}${includedir}/lac"
> > +export KERNEL_SOURCE_ROOT = "${STAGING_KERNEL_DIR}"
> > +export KERNEL_BUILDDIR = "${STAGING_KERNEL_BUILDDIR}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +do_unpack2() {
> > +        cd ${WORKDIR}/openssl_qat-${PV}
> > +        cd libcrypto_shim_${PV}_*
> > +        tar -zxof libCrypto_Shim_${PV}.tar.gz
> > +        tar -zxof libcrypto-openssl-${OPENSSL_VERSION}-
> > qat.L.${PV}.tar.gz
> > +        mv openssl-${OPENSSL_VERSION}-qat.patch ${WORKDIR}
> > +}
> > +
> For embedded shell functions like the do_*, tabs are used for the white
> space. If you create a python function then our convention is for 4
> space indent levels.

 corrected it in v2.


Thanks,
Rahul

> 
> > +addtask unpack2 after do_unpack before do_patch_prepend
> > +
> > +do_prepatch() {
> > +        cd ${S}