[meta-intel] [meta-isg][fido][master][PATCH] meta-isg: dpdk: fix incorrect config fix-up patch and also tidy up dpdk.inc

[Ong, Boon Leong]

>-----Original Message-----
>From: meta-intel-bounces at yoctoproject.org [mailto:meta-intel-
>bounces at yoctoproject.org] On Behalf Of Darren Hart
>Sent: Tuesday, July 28, 2015 1:47 AM
>To: Wu, Chia Chuan
>Cc: meta-intel at yoctoproject.org
>Subject: Re: [meta-intel] [meta-isg][fido][master][PATCH] meta-isg: dpdk: fix
>incorrect config fix-up patch and also tidy up dpdk.inc
>
>
>
>On 7/27/15 4:14 AM, chia.chuan.wu at intel.com wrote:
>> From: Ong Boon Leong <boon.leong.ong at intel.com>
>>
>> This patch fixes issue in build configuration variables that were not
>> correctly parsed by do_configure() task. The environment variables
>> introduced by below patches, $(DPDK_TARGET_MACH) &
>> $(CONFIG_VHOST_ENABLED) are not evaluated because the config files
>> under dpdk/config/ folder are not parsed by Makefile but instead by cpp
>compiler.
>>
>>
>> dpdk/dpdk-1.8.0-and-2.0.0-dpdk-defconfig-select-RTE_MACHINE-type.patch
>>
>> dpdk/dpdk-1.8.0-dpdk-enable-build-config-VHOST-in-common_linuxapp-conf
>> ig.patch
>> dpdk/dpdk-2.0.0-dpdk-enable-VHOST-and-ip_fragmentation-in-
>common_linux
>> app.patch
>>
>> Thanks to Anuj Mittal for detecting the issue above.
>>
>> So, we fix the above issues by using sed command to fix-up the right
>> values as follow
>>
>> 1) Override the value of CONFIG_RTE_MACHINE based on MACHINE_ARCH at
>>    config/defconfig_x86_64-native-linuxapp-gcc
>>    config/defconfig_i686-native-linuxapp-gcc
>>
>> 2) Override the value of CONFIG_RTE_KNI_VHOST,
>CONFIG_RTE_KNI_VHOST_VNET_HDR_EN and
>>    CONFIG_RTE_LIBRTE_VHOST based on PACKAGECONFIG[vhost] at
>>    config/common_linuxapp
>>
>> Since we are here, we also take opportunity to tidy up dpdk.inc by
>> integrating common recipe from dpdk_1.8.0.bb & dpdpk_2.0.0.bb
>
>This is at least 2 distinct functional changes and should be made as separate
>commits. At the very least, please separate the .inc common changes into their
>own patch.
Darren, 

Chia Chuan will make the changes for DPDK, collect the patches from Anuj on
The zlib-qat and dpdk dependency on the "virtual/qat" thread and sent in one 
single patch-series to you. He will be using a different subject title so that you are
aware that you can merge that patch-series instead of merging from two other submits.

Thanks
Boon Leong