[meta-intel] [fido][PATCH v2 1/2] meta-crystalforest: qat recipe for riverforest

[Mittal, AnujX]

Thank you for your comments.

> > +
> > +#Dual BSD and GPLv2 License
> > +LICENSE = "BSD & GPLv2"
> > +LIC_FILES_CHKSUM = "\
> > +                    file://${COMMON_LICENSE_DIR}/GPL-
> 2.0;md5=801f80980d171dd6425610833a22dbe6 \
> > +
> file://${COMMON_LICENSE_DIR}/BSD;md5=3775480a712fc46a69647678acb234cb \
> > +                    "
> > +PV = "2.3.0-34"
> > +DEPENDS += "zlib openssl"
> 
> You seem to have different DEPENDS than the dizzy one is that intended?

I have left out pkgconfig & cryptodev-linux. I don't think they are required in this case.

> > +
> > +export QAT_VERSION = "2.3.0-34"
> > +export ICP_DH895X = "QAT1.6"
> > +export ICP_DRIVER_TYPE = "${ICP_DH895X}"
> > +export ICP_FIRMWARE_DIR="dh895xcc"
> > +export ICP_ROOT = "${S}"
> > +export ICP_ENV_DIR = "${S}/quickassist/build_system/build_files/env_files"
> > +export ICP_BUILDSYSTEM_PATH = "${S}/quickassist/build_system"
> > +export ICP_TOOLS_TARGET = "${ICP_TOOLS}"
> > +export FUNC_PATH =
> "${ICP_ROOT}/quickassist/lookaside/access_layer/src/sample_code/functional"
> > +export BUILD_DIR = "${S}/build"
> > +export KERNEL_SOURCE_ROOT = "${STAGING_KERNEL_DIR}"
> > +export ICP_BUILD_OUTPUT = "${BUILD_DIR}"
> > +export DEST_LIBDIR = "${libdir}"
> > +export DEST_BINDIR = "${bindir}"
> > +export QAT_KERNEL_VER = "${KERNEL_VERSION}"
> > +export SAMPLE_BUILD_OUTPUT = "${BUILD_DIR}"
> > +export MODULE_DIR =
> "${base_libdir}/modules/${KERNEL_VERSION}/kernel/drivers"
> > +
> Are all of these variables really needed?  The Dizzy one has fewer.
> Again, I suggest reviewing the dizzy verison.

Have removed two in v3. I'm using two extra variables to pass them on to makefiles for install.

> > +
> > +do_install_prepend() {
> > +        cp -Pr ${BUILD_DIR}/* ${D}
> > +}
> > +
> Honestly, I am still not liking this copy.  We should be properly using
> install to place files into ${D}, doing a blind copy we don't really
> know what gets copied.
> 
> Sau!
> 

Have re-visited my work & the new version should look much cleaner. It has an install target in the makefiles & avoids this copy. Thank you for reviewing.

Thanks!

-Anuj