[meta-intel] [fido][PATCH v2 1/2] meta-crystalforest: qat recipe for riverforest

[Saul Wold]

On 07/06/2015 10:45 PM, anujx.mittal at intel.com wrote:
> From: Anuj Mittal <anujx.mittal at intel.com>
>
> This implements the support for Intel QAT 2.3.0-34
> for Intel RiverForest platforms on YP Fido.
>
> Signed-off-by: Anuj Mittal <anujx.mittal at intel.com>
> ---
>   .../recipes-extended/qat/qat16_2.3.0-34.bb         |  117 ++++++++++++++++++++
>   1 file changed, 117 insertions(+)
>   create mode 100644 meta-crystalforest/recipes-extended/qat/qat16_2.3.0-34.bb
>
> diff --git a/meta-crystalforest/recipes-extended/qat/qat16_2.3.0-34.bb b/meta-crystalforest/recipes-extended/qat/qat16_2.3.0-34.bb
> new file mode 100644
> index 0000000..4242ebd
> --- /dev/null
> +++ b/meta-crystalforest/recipes-extended/qat/qat16_2.3.0-34.bb
> @@ -0,0 +1,117 @@
> +DESCRIPTION = "Intel(r) QuickAssist Technology API"
> +HOMEPAGE = "https://01.org/packet-processing/intel%C2%AE-quickassist-technology-drivers-and-patches"
> +
> +#Dual BSD and GPLv2 License
> +LICENSE = "BSD & GPLv2"
> +LIC_FILES_CHKSUM = "\
> +                    file://${COMMON_LICENSE_DIR}/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6 \
> +                    file://${COMMON_LICENSE_DIR}/BSD;md5=3775480a712fc46a69647678acb234cb \
> +                    "
> +PV = "2.3.0-34"
> +DEPENDS += "zlib openssl"

You seem to have different DEPENDS than the dizzy one is that intended?

> +SRC_URI="https://01.org/sites/default/files/page/qatmux.l.${PV}.tgz;name=qat \
> +         file://qat16_2.3.0-34-qat-remove-local-path-from-makefile.patch \
> +         file://qat16_2.3.0-34-qat-add-generic-paths-to-makefile-for-install.patch \
> +         file://qat16_2.3.0-34-qat-tweak-sample-code-makefiles.patch \
> +         "
> +
> +SRC_URI[qat.md5sum] = "9614bf598bc8e7eedc8adb6d29109033"
> +SRC_URI[qat.sha256sum] = "1f9708de3c132258eaa488c82760f374b6b6838c85cafef2e8c61034fe0f7031"
> +
> +COMPATIBLE_MACHINE = "crystalforest"
> +
> +S = "${WORKDIR}/${ICP_DRIVER_TYPE}"
> +ICP_TOOLS = "accelcomp"
> +SAMPLE_CODE_DIR = "${S}/quickassist/lookaside/access_layer/src/sample_code"
> +
> +export QAT_VERSION = "2.3.0-34"
> +export ICP_DH895X = "QAT1.6"
> +export ICP_DRIVER_TYPE = "${ICP_DH895X}"
> +export ICP_FIRMWARE_DIR="dh895xcc"
> +export ICP_ROOT = "${S}"
> +export ICP_ENV_DIR = "${S}/quickassist/build_system/build_files/env_files"
> +export ICP_BUILDSYSTEM_PATH = "${S}/quickassist/build_system"
> +export ICP_TOOLS_TARGET = "${ICP_TOOLS}"
> +export FUNC_PATH = "${ICP_ROOT}/quickassist/lookaside/access_layer/src/sample_code/functional"
> +export BUILD_DIR = "${S}/build"
> +export KERNEL_SOURCE_ROOT = "${STAGING_KERNEL_DIR}"
> +export ICP_BUILD_OUTPUT = "${BUILD_DIR}"
> +export DEST_LIBDIR = "${libdir}"
> +export DEST_BINDIR = "${bindir}"
> +export QAT_KERNEL_VER = "${KERNEL_VERSION}"
> +export SAMPLE_BUILD_OUTPUT = "${BUILD_DIR}"
> +export MODULE_DIR = "${base_libdir}/modules/${KERNEL_VERSION}/kernel/drivers"
> +
Are all of these variables really needed?  The Dizzy one has fewer.
Again, I suggest reviewing the dizzy verison.

> +inherit module
> +inherit update-rc.d
> +INITSCRIPT_NAME = "qat_service"
> +
> +PARALLEL_MAKE = ""
> +
> +#To get around the double slashes in paths in QAT makefiles
> +PACKAGE_DEBUG_SPLIT_STYLE = "debug-without-src"
> +
> +do_unpack2() {
> +        cd ${S}/
> +        tar xzvf ${ICP_DRIVER_TYPE}.L.${QAT_VERSION}.tar.gz
> +}
> +
> +addtask unpack2 after do_unpack before do_patch
> +
> +do_compile () {
> +        export LD="${LD} --hash-style=gnu"
> +        export MACHINE="${TARGET_ARCH}"
> +        cd ${S}/quickassist
> +        oe_runmake EXTRA_OEMAKE="'CFLAGS=${CFLAGS} -fPIC'"
> +
> +        cd ${SAMPLE_CODE_DIR}
> +        touch ${SAMPLE_CODE_DIR}/performance/compression/calgary
> +        touch ${SAMPLE_CODE_DIR}/performance/compression/canterbury
> +	
> +        #build the whole sample code: fips, functional, performance
> +        oe_runmake 'all'
> +        oe_runmake 'fips_user_code'
> +}
> +
> +do_install_prepend() {
> +        cp -Pr ${BUILD_DIR}/* ${D}
> +}
> +
Honestly, I am still not liking this copy.  We should be properly using 
install to place files into ${D}, doing a blind copy we don't really 
know what gets copied.

Sau!

> +do_install() {
> +        install -d ${D}/etc/udev/rules.d \
> +                   ${D}${includedir} \
> +                   ${D}${includedir}/dc \
> +                   ${D}${includedir}/lac \
> +                   ${D}${sysconfdir}/dh895xcc \
> +                   ${D}${base_libdir}/firmware
> +
> +        echo 'KERNEL=="icp_adf_ctl" MODE="0600"' > ${D}/etc/udev/rules.d/00-dh895xcc_qa.rules
> +        echo 'KERNEL=="icp_dev[0-9]*" MODE="0600"' >> ${D}/etc/udev/rules.d/00-dh895xcc_qa.rules
> +        echo 'KERNEL=="icp_dev_mem?" MODE="0600"' >> ${D}/etc/udev/rules.d/00-dh895xcc_qa.rules
> +
> +        install -m 640 ${S}/quickassist/include/*.h ${D}${includedir}
> +        install -m 640 ${S}/quickassist/include/dc/*.h ${D}${includedir}
> +        install -m 640 ${S}/quickassist/include/lac/*.h ${D}${includedir}
> +        install -m 640 ${S}/quickassist/lookaside/access_layer/include/*.h ${D}${includedir}
> +
> +        install -m 0755 ${SAMPLE_CODE_DIR}/performance/compression/calgary     ${D}${base_libdir}/firmware
> +        install -m 0755 ${SAMPLE_CODE_DIR}/performance/compression/canterbury  ${D}${base_libdir}/firmware
> +
> +        install -m 660  ${S}/quickassist/config/dh* ${D}${sysconfdir}/dh895xcc
> +}
> +
> +PACKAGES += "${PN}-app"
> +
> +FILES_${PN}-dev = "${includedir}"
> +
> +FILES_${PN} += "\
> +                ${base_libdir}/firmware/    \
> +                ${sysconfdir}/              \
> +                ${sysconfdir}/udev/rules.d/ \
> +                ${sysconfdir}/init.d/       \
> +                ${libdir}/                  \
> +                "
> +
> +FILES_${PN}-dbg += "${sysconfdir}/init.d/.debug"
> +
> +FILES_${PN}-app += "${bindir}/*"
>