[meta-intel] [PATCH 2/2] meta-intel.inc: allow disabling of Intel microcode

[Hart, Darren]

On 9/17/14, 12:44, "Kamble, Nitin A" <nitin.a.kamble at intel.com> wrote:

>From: Nitin A Kamble <nitin.a.kamble at intel.com>
>
>As per request from Tom, allow disabling of the Intel microcode
>feature for meta-intel BSPs.
>
>If one adds this line to local.conf while build a meta-intel BSP,
>the microcode feature will be disabled for the build target.
>
>DISABLE_INTEL_MICROCODE = "1"

No, we had this discussion. These BSPs need to build out of the box
without special flags to disable feature that would otherwise break it on
supported systems. If Microcode can't be enabled generically and safely,
then it needs to be opt-in, not opt-out.

--
Darren

>
>Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
>---
> conf/machine/include/meta-intel.inc | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/conf/machine/include/meta-intel.inc
>b/conf/machine/include/meta-intel.inc
>index f43903e..e8134a7 100644
>--- a/conf/machine/include/meta-intel.inc
>+++ b/conf/machine/include/meta-intel.inc
>@@ -20,10 +20,11 @@ XSERVER_X86_MATROX_MGA = "xf86-video-mga \
> 
> XSERVER_X86_ASPEED_AST = "xf86-video-ast \
>            "
>-
>+# if not disabled,
> # include the user space intel microcode loading support in the
>generated images.
>-MACHINE_ESSENTIAL_EXTRA_RDEPENDS_append = " intel-microcode iucode-tool"
>+MACHINE_ESSENTIAL_EXTRA_RDEPENDS_append = "${@[' intel-microcode
>iucode-tool', ''][d.getVar('DISABLE_INTEL_MICROCODE', True) != '1']}"
> 
>-# For the early boot time kernel microcode loading support,
>+# if not disabled,
>+# for the early boot time kernel microcode loading support,
> # merge the microcode data in the final initrd image.
>-INITRD_prepend = "${DEPLOY_DIR_IMAGE}/microcode.cpio "
>+INITRD_prepend = "${@['${DEPLOY_DIR_IMAGE}/microcode.cpio ',
>''][d.getVar('DISABLE_INTEL_MICROCODE', True) != '1']}"
>-- 
>1.8.1.4
>
>


-- 
Darren Hart					Open Source Technology Center
darren.hart at intel.com				            Intel Corporation