[meta-freescale] [v3,04/43] weston: Fix non-GPU support

[Tom Hochstein]

Hi Gary,

The problem is the upstreaming is incomplete. I am working with Otavio on another set of patches that will fix this.

Tom

-----Original Message-----
From: Gary Bisson <gary.bisson at boundarydevices.com> 
Sent: Friday, September 7, 2018 3:05 AM
To: Tom Hochstein <tom.hochstein at nxp.com>
Cc: meta-freescale at yoctoproject.org
Subject: Re: [v3,04/43] weston: Fix non-GPU support

Hi Tom,

On Tue, Aug 07, 2018 at 10:41:56AM -0500, Tom Hochstein wrote:
> The desktop failed to start on i.MX parts without GPU. The problem is 
> fixed, and now the package must be configured for i.MX GPU support.
> 
> Signed-off-by: Tom Hochstein <tom.hochstein at nxp.com>
> ---
>  recipes-graphics/wayland/weston_4.0.0.imx.bb | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/recipes-graphics/wayland/weston_4.0.0.imx.bb 
> b/recipes-graphics/wayland/weston_4.0.0.imx.bb
> index fc6a65f..7a2aab6 100644
> --- a/recipes-graphics/wayland/weston_4.0.0.imx.bb
> +++ b/recipes-graphics/wayland/weston_4.0.0.imx.bb
> @@ -15,7 +15,7 @@ SRC_URI = "git://source.codeaurora.org/external/imx/weston-imx.git;protocol=http
>             file://xwayland.weston-start \
>             
> file://0001-weston-launch-Provide-a-default-version-that-doesn-t.patch \  "
> -SRCREV = "bf74309dd16d86537ff07eabf8b499cb2d25277d"
> +SRCREV = "642006cbd89e7ae51a7ce672c899614814dc4ef0"

Have you tested this patch only with a non-GPU configuration?

Because this revision simply fails to build currently for configuration with GPU, giving the following error:
| make: *** No rule to make target 'protocol/alpha-compositing-unstable-v1-protocol.c', needed by 'all'.  Stop.
| ERROR: oe_runmake failed

And indeed the source code seems broken as this patch relies on files that were not pushed:
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.codeaurora.org%2Fexternal%2Fimx%2Fweston-imx%2Fcommit%2F%3Fid%3D26172d61&data=02%7C01%7Ctom.hochstein%40nxp.com%7Cafaf2673728b4acfb5ba08d61498ad18%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636719043304342156&sdata=iwYl2Cj9qoPmRRnkvt%2FHf%2BQ21P%2F30yQ4%2BqftayA0nKk%3D&reserved=0

It's missing:
protocol/alpha-compositing-unstable-v1-protocol.c
protocol/alpha-compositing-unstable-v1-client-protocol.h
protocol/alpha-compositing-unstable-v1-server-protocol.h

Please have the Weston team add the missing files or submit a revert patch to meta-freescale.

Regards,
Gary