[meta-freescale] [PATCH] imx-uuc: Fix missing build ldflags leading to QA issues

Gianfranco Costamagna gianfranco.costamagna at abinsula.com
Tue Oct 3 00:18:08 PDT 2017


---
 ...ng-build-flags-leading-to-yocto-QA-issues.patch | 44 ++++++++++++++++++++++
 recipes-bsp/imx-uuc/imx-uuc_git.bb                 |  3 +-
 2 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 recipes-bsp/imx-uuc/imx-uuc/0001-Fix-missing-build-flags-leading-to-yocto-QA-issues.patch

diff --git a/recipes-bsp/imx-uuc/imx-uuc/0001-Fix-missing-build-flags-leading-to-yocto-QA-issues.patch b/recipes-bsp/imx-uuc/imx-uuc/0001-Fix-missing-build-flags-leading-to-yocto-QA-issues.patch
new file mode 100644
index 0000000..090fb3a
--- /dev/null
+++ b/recipes-bsp/imx-uuc/imx-uuc/0001-Fix-missing-build-flags-leading-to-yocto-QA-issues.patch
@@ -0,0 +1,44 @@
+From bfdf01bfb462b21cf0a8f3e35d160b8ee4cea4ab Mon Sep 17 00:00:00 2001
+From: Gianfranco Costamagna <gianfranco.costamagna at abinsula.com>
+Date: Tue, 3 Oct 2017 08:58:08 +0200
+Subject: [PATCH] Fix missing build flags, leading to yocto QA issues
+
+ERROR: imx-uuc-0.5.1+gitAUTOINC+1de598e7b3-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'imx-uuc/0.5.1+gitAUTOINC+1de598e7b3-r0/packages-split/imx-uuc/usr/bin/uuc'
+No GNU_HASH in the elf binary: 'imx-uuc/0.5.1+gitAUTOINC+1de598e7b3-r0/packages-split/imx-uuc/usr/bin/sdimage' [ldflags]
+
+similar issues have been reported on meta-freescale mail list too and then I'm attaching the Found-by/Signed-off-by flags correspondingly:
+(the patches were against meta-freescale, I'm upstreaming them with some little changes)
+https://lists.yoctoproject.org/pipermail/meta-freescale/2017-April/020355.html
+
+Found-by: Gianfranco Costamagna <gianfranco.costamagna at abinsula.com>
+Found-by: Joel Esponde <Joel.Esponde at Honeywell.com>
+Signed-off-by: Bas Mevissen <bas.mevissen at emcodev.nl>
+---
+ Makefile | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index 5e2816c..1a8f51f 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,14 +1,15 @@
+ CC ?= $(CROSS_COMPILE)gcc
+ BINDIR ?= /usr/bin
+ PROGRAMS = uuc sdimage
++LIBS ?= -lpthread
+ 
+ all: $(PROGRAMS)
+ 
+ uuc: uu.c
+-	$(CC) $(CFLAGS) uu.c -o uuc -lpthread
++	$(CC) $(CFLAGS) $(CPPFLAGS) uu.c -o uuc $(LDFLAGS) $(LIBS) 
+ 
+ sdimage: sdimage.c
+-	$(CC) $(CFLAGS) sdimage.c -o sdimage
++	$(CC) $(CFLAGS) $(CPPFLAGS) sdimage.c -o sdimage $(LDFLAGS)
+ 
+ install:
+ 	install -d $(DESTDIR)$(BINDIR)
+-- 
+2.11.0
+
diff --git a/recipes-bsp/imx-uuc/imx-uuc_git.bb b/recipes-bsp/imx-uuc/imx-uuc_git.bb
index 8c1a81d..a019fa1 100644
--- a/recipes-bsp/imx-uuc/imx-uuc_git.bb
+++ b/recipes-bsp/imx-uuc/imx-uuc_git.bb
@@ -10,7 +10,8 @@ inherit autotools-brokensep
 
 PV = "0.5.1+git${SRCPV}"
 
-SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocol=https"
+SRC_URI = "git://github.com/NXPmicro/imx-uuc.git;protocol=https \
+           file://0001-Fix-missing-build-flags-leading-to-yocto-QA-issues.patch "
 SRCREV = "1de598e7b36d95596435902106c9a746697b9afc"
 
 S = "${WORKDIR}/git"
-- 
2.7.4



More information about the meta-freescale mailing list