[meta-freescale] [PATCH 1/2] ipc-ust: move SOC specific variables to qoriq-base.inc

[Otavio Salvador]

On Tue, Sep 1, 2015 at 5:28 AM, Zhenhua Luo <zhenhua.luo at freescale.com> wrote:
> * Add IPC_UST_SOC variables in qoriq-base.inc to define SOC type for ipc-ust
> * Use IPC_UST_SOC in ipc-ust bb file
>
> Signed-off-by: Zhenhua Luo <zhenhua.luo at freescale.com>

This is closer :-) but ...

> ---
>  conf/machine/include/qoriq-base.inc     |  4 ++++
>  recipes-extended/ipc-ust/ipc-ust_git.bb | 10 ++++++----
>  2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/conf/machine/include/qoriq-base.inc b/conf/machine/include/qoriq-base.inc
> index 1b49cc4..f85f18e 100644
> --- a/conf/machine/include/qoriq-base.inc
> +++ b/conf/machine/include/qoriq-base.inc
> @@ -20,4 +20,8 @@ MACHINE_EXTRA_RRECOMMENDS ?= "udev-rules-qoriq"
>
>  EXTRA_IMAGEDEPENDS += "u-boot cst-native"
>
> +IPC_UST_SOC_bsc9131 = "B913x"
> +IPC_UST_SOC_bsc9132 = "B913x"
> +IPC_UST_SOC_b4 = "B4860"
> +
>  MACHINEOVERRIDES .= ":qoriq"

Good.

> diff --git a/recipes-extended/ipc-ust/ipc-ust_git.bb b/recipes-extended/ipc-ust/ipc-ust_git.bb
> index 5ba3411..5012bfa 100644
> --- a/recipes-extended/ipc-ust/ipc-ust_git.bb
> +++ b/recipes-extended/ipc-ust/ipc-ust_git.bb
> @@ -13,10 +13,12 @@ PARALLEL_MAKE = ""
>  EXTRA_OEMAKE = 'CROSS_COMPILE="${TARGET_PREFIX}" CC="${CC}" AR="${AR}"'
>
>  do_compile () {
> -    case ${MACHINE} in
> -        bsc9132qds|bsc9131rdb) SOC=B913x;;
> -        b4860qds|b4420qds|b4860qds-64b) SOC=B4860;;
> -    esac
> +    if [ "${IPC_UST_SOC}" == "" ]; then
> +        echo "WARNING: IPC_UST_SOC is not defined in qoriq-base.inc."
> +        continue
> +    fi

This should be an anonymous python code to check the recipe at parsing
time. See:

http://git.openembedded.org/openembedded-core/tree/meta/classes/uboot-config.bbclass#n14

> +    SOC="${IPC_UST_SOC}"
>      oe_runmake ${SOC}=1

Use:

     oe_runmake ${IPC_UST_SOC}=1

So we avoid one indirection :)

>  }

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750