[meta-freescale] [meta-fsl-arm][PATCH v8] pulseaudio: Add PulseAudio configuration

[Otavio Salvador]

On Tue, Aug 25, 2015 at 5:55 AM, Nikolay Dimitrov <picmaster at mail.bg> wrote:
> On 08/22/2015 12:16 AM, Otavio Salvador wrote:
>>
>> On Fri, Aug 21, 2015 at 11:38 AM, Yuqing Zhu <b54851 at freescale.com> wrote:
>>>
>>> +IMX_PATCHES = " file://daemon.conf \
>>> +                file://default.pa \
>>> +"
>>> +SRC_URI_append_mx6 = "${IMX_PATCHES}"
>>> +SRC_URI_append_mx7 = "${IMX_PATCHES}"
>>
>>
>> I see no need to add a new variable for such simple append. You can
>> rewrite this as:
>>
>> SRC_URI_append_mx6 = " file://daemon.conf file://default.pa"
>> SRC_URI_append_mx7 = " file://daemon.conf file://default.pa"
>
>
> The only wrong thing here is the variable name (IMX_PATCHES), as these
> are config files and not patches. A better one would be IMX_PA_CONFIGS.
>
> The change you proposed will now force the developer to duplicate and
> manually keep in sync the 2 lists of config files.

I am fine with this proposal as well; as it are two items only using a
variable seems overkill for me but I see no problem. Your proposed
variable name (IMX_PA_CONFIGS) is indeed better, if used.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750