[meta-freescale] [meta-fsl-arm][PATCH v8] pulseaudio: Add PulseAudio configuration

Nikolay Dimitrov picmaster at mail.bg
Tue Aug 25 01:55:28 PDT 2015


Hi Otavio,

On 08/22/2015 12:16 AM, Otavio Salvador wrote:
> On Fri, Aug 21, 2015 at 11:38 AM, Yuqing Zhu <b54851 at freescale.com> wrote:
>> +IMX_PATCHES = " file://daemon.conf \
>> +                file://default.pa \
>> +"
>> +SRC_URI_append_mx6 = "${IMX_PATCHES}"
>> +SRC_URI_append_mx7 = "${IMX_PATCHES}"
>
> I see no need to add a new variable for such simple append. You can
> rewrite this as:
>
> SRC_URI_append_mx6 = " file://daemon.conf file://default.pa"
> SRC_URI_append_mx7 = " file://daemon.conf file://default.pa"

The only wrong thing here is the variable name (IMX_PATCHES), as these
are config files and not patches. A better one would be IMX_PA_CONFIGS.

The change you proposed will now force the developer to duplicate and
manually keep in sync the 2 lists of config files.

Regards,
Nikolay


More information about the meta-freescale mailing list