[meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS)

[Daiane Angolini]

On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci
<gianluca.cinci at giuneco.it> wrote:
> Hi Daiane,
> sure , the patch is attached to this mail (let me know if I must to change
> it)

Thanks, when send a patch to meta-freescale, please use git send email
(I think you did this the first time, right?

I copied your patch at the end of this reply, because I have some comments.

I cannot comment properly on the gpu code itself, so I would expect
someone else to also comment on the patch.


> About the cinematicexperience + eglfs dependecies:
> With the only inclusion  of cinematicexperience the "EGL..." error come out
> , so i must to add the "amd-gpu-bin-mx51" package to have all the necessary
> library on my fs.


Oh, and please, do not top-post.

>
> Bests Regards
> Gianluca
>

your patch:
(I added 2 comments inline)


>From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 2001
From: gianluca <gianluca at giuneco.it>
Date: Thu, 13 Nov 2014 00:11:51 +0100
Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free issue on
 application exit

[Daiane]
For this subject please use something like:

[meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid
shared memory free issue.

use as example:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-kernel/linux/linux-imx_2.6.35.3.bb


Signed-off-by: gianluca <gianluca at giuneco.it>
---
 .../avoid-shared-memory-free-issue.patch           | 26 ++++++++++++++++++++++
 recipes-kernel/linux/linux-imx_2.6.35.3.bb         |  1 +
 2 files changed, 27 insertions(+)
 create mode 100644
recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch

diff --git a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch
b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch
new file mode 100644
index 0000000..a109cc0
--- /dev/null
+++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch
@@ -0,0 +1,26 @@
+From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001
+From: gianluca <gianluca at giuneco.it>
+Date: Tue, 11 Nov 2014 22:25:17 +0100
+Subject: [PATCH] avoid shared memory free issue on application exit

[Daiane]

For this subject use:
[PATCH] imx: amd-gpu: avoid shared memory free issue on application

and add the tag Upstream-Status, use as example
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations


+
+---
+ drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c
b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c
+index 51e66f9..2529267 100644
+--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c
++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c
+@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc,
unsigned int pid)
+     }
+     else
+     {
++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL);  // free the
previously allocated memory if
++      // gpuaddress is present in gsl_linux_map_list
++
+         status = GSL_FAILURE;
+     }
+
+--
+1.9.1
+
diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb
b/recipes-kernel/linux/linux-imx_2.6.35.3.bb
index bfc56b7..ad1f10b 100644
--- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb
+++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb
@@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain"
 SRC_URI += "file://NFS-Fix-nfsroot-support.patch \
             file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \
             file://perf-avoid-use-sysroot-headers.patch \
+     file://avoid-shared-memory-free-issue.patch \
 "


 SRC_URI_append_mx28 = " \
-- 
1.9.1


Daiane