[meta-freescale] [meta-fsl-ppc][PATCH 04/12] conf/machine/: move common bits to inc files

[ting.liu at freescale.com]

> -----Original Message-----
> From: otavio.salvador at gmail.com [mailto:otavio.salvador at gmail.com] On Behalf
> Of Otavio Salvador
> Sent: Saturday, July 12, 2014 1:17 AM
> To: Liu Ting-B28495
> Cc: meta-freescale at yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH 04/12] conf/machine/: move
> common bits to inc files
> 
> Hello,
> 
> On Fri, Jul 11, 2014 at 5:09 AM,  <ting.liu at freescale.com> wrote:
> > From: Ting Liu <b28495 at freescale.com>
> >
> > * add four new files to hold common bits:
> >    include/qoriq-base.inc
> >    include/qoriq-default-providers.inc
> >    include/qoriq-default-settings.inc
> >    include/qoriq-default-versions.inc
> > * add 'qoriq' into list of MACHINEOVERRIDES
> >
> > Signed-off-by: Ting Liu <b28495 at freescale.com>
> 
> I really like the idea and I think it goes in the right direction. The only
> concern I have is that the qoriq-default-settings hides many things which are
> /board specific/. I am sure customers use different serial console devices for
> example so everything which vary in customers boards are not qoriq-base stuff.
> 
> Does it makes sense?

Yes, it does. I use ?= in patch v2 for SERIAL_CONSOLES settings.

IMO, user can always override it in board.conf after including the inc file :)


> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750