[meta-freescale] [meta-fsl-arm][PATCH v2 4/6] Add rcw recipe for Layerscape1 support

[zhenhua.luo at freescale.com]

> -----Original Message-----
> From: otavio.salvador at gmail.com [mailto:otavio.salvador at gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Wednesday, August 27, 2014 9:07 PM
> 
> On Wed, Aug 27, 2014 at 1:57 AM, Zhenhua Luo <zhenhua.luo at freescale.com>
> wrote:
> > +
> > +export PYTHON
> > +do_compile_append () {
> > +    if [ "ls1021aqds" = "${M}" ];then
> > +       for img in `find ${S} -name "*qspiboot*.bin"`; do
> > +           img_swap=`echo ${img} | awk
> '{sub("qspiboot","qspiboot_swap"); print $0}'`
> > +           ${bindir}/tclsh ${M}/byte_swap.tcl ${img} ${img_swap} 8
> > +       done
> > +    fi
> 
> The tcl file needs to come from a dependency so we need, as I said in the
> u-boot patch, split it out and have it as dependency here. Another thing,
> this calls should be moved to the Makefile and have a RCW_MACHINE concept
> or similar.
[Luo Zhenhua-B19537] Yes, the tcl script can be splitted as a separated recipe(E.g. uboot-byteswap-tool). U-boot and rcw can depends on it. This can avoid duplicated location of same script. 

> > +do_install () {
> > +    make install
> > +
> > +    M=`echo ${MACHINE} | sed s/-64b//g`
> > +    for img in `find ${S} -name "*qspiboot_swap*.bin"`; do
> > +        rcw_subdir="`dirname ${img} | xargs basename`"
> > +        install ${img} ${S}/${M}/${M}/${rcw_subdir}
> > +    done
> > +
> > +    install -d ${D}/boot/rcw
> > +    cp -r ${S}/${M}/${M}/* ${D}/boot/rcw
> 
> This should be done in the Makefile.
[Luo Zhenhua-B19537] I will try to update the Makefile. 

> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +COMPATIBLE_HOST_ls102xa = "arm-poky-linux-gnueabi"
> 
> This makes this not compatible with custom SDKs.
[Luo Zhenhua-B19537] Seems like above line is not needed, I will double-check. 

> > +COMPATIBLE_MACHINE = "(ls1021aqds|ls1021atwr)"
> 
> I'd use SoC family.
[Luo Zhenhua-B19537] Sounds good. 


Best Regards,

Zhenhua