[yocto] [PATCH] [yocto-ab-helper] utils.py: Resolved unicode data expansion

[Chan, Aaron Chun Yew]

Hi Richard,

This is what I did on which you asked me to do

~/yocto-autobuilder-helper/janitor/clobberdir

1. Change to use python3 
    #!/usr/bin/env/python2 to #!/usr/bin/env/python3
    
    Retain and add print to debug message
    trashdir = ourconfig["TRASH_DIR"]
    print(trashdir)   

Results:
mv: cannot move '/home/pokybuild/yocto-worker/nightly-x86-64-bsp/' to a subdirectory of itself, '${BASE_HOMEDIR}/git/trash/1530767509-20564/nightly-x86-64-bsp'
${BASE_HOMEDIR}/git/trash   <----------------------- debug message
Traceback (most recent call last):
  File "/home/pokybuild/yocto-autobuilder-helper/janitor/clobberdir", line 54, in <module>
    subprocess.check_call(['mv', x, trashdest])
  File "/usr/lib/python3.5/subprocess.py", line 581, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['mv', '/home/pokybuild/yocto-worker/nightly-x86-64-bsp/', '${BASE_HOMEDIR}/git/trash/1530767509-20564']' returned non-zero exit status 1
program finished with exit code 1

2. Change to use python3
    #!/usr/bin/env python2 to #!/usr/bin/env/python3
    
    Change and print to debug message
    trashdir = utils.getconfig("TRASH_DIR", ourconfig)
    print(trashdir)

Results:
using PTY: False
/home/pokybuild/git/trash      <----------------------- debug message
program finished with exit code 0
elapsedTime=0.050781

I'll updated the patch on Item 2 in https://lists.yoctoproject.org/pipermail/yocto/2018-July/041694.html
Thanks,

Best wishes,
Aaron
________________________________________
From: richard.purdie at linuxfoundation.org [richard.purdie at linuxfoundation.org]
Sent: Wednesday, July 04, 2018 3:51 PM
To: Chan, Aaron Chun Yew; yocto at yoctoproject.org
Subject: Re: [PATCH] [yocto-ab-helper] utils.py: Resolved unicode data expansion

Hi Aaron,

On Wed, 2018-07-04 at 06:42 +0000, Chan, Aaron Chun Yew wrote:
> This morning I had the new autobuilder setup from scratch with the
> latest patch you just check out, thanks for that and rollout the fix
> below manually. Everything else is clean and I did what you asked me
> to.
> However this did not resolved the data expansion when called
> utils.getconfig("REPO_STASH_DIR, ourconfig), this applies when you
> invoke ourconfig["REPO_STASH_DIR"]. Both yields the same errors.
> We assume the  JSON dumps are properly handled in ourconfig[c] when
> we handles config[c] but that is not the case. I do see there is a
> growing issues as your strategy to use nested JSON, however
> we wont be able to handle all of these conditions needed when nested
> JSON becomes complex. Anyway, i'll leave it you decide what will be
> best course of action.

I had another look at this as we shouldn't be seeing unicode items in
this in python3. I've realised that clobberdir is using python2. If you
change clobberdir to use python3 does this mean the unicode part of the
patch is no longer needed? I think that may be the real problem!

Cheers,

Richard