[yocto] [pyro][meta-oracle-java][PATCH 2/2] oracle-java: create directory before creating links

[Vincent Prince]

Hi Fabio,

I have a non fatal-error on link creation on pyro:

ERROR: oracle-jse-jdk-x86-64-native-1.8.0-u131r0 do_populate_sysroot:
sstate found an absolute path symlink
/home/build/tmp/work/x86_64-linux/oracle-jse-jdk-x86-64-native/1.8.0-u131r0/sysroot-destdir/home/build/tmp/work/x86_64-linux/oracle-jse-jdk-x86-64-native/1.8.0-u131r0/recipe-sysroot-native/usr/bin/java
pointing at /home/build/tmp/work/x86_64-linux/oracle-jse-jdk-x86-64-native/1.8.0-u131r0/recipe-sysroot-native/usr/lib/jvm/java-8-oracle/bin/java.
Please replace this with a relative link.

I suspect that those lines are concerned:
        ln -sf ${JDK_HOME}/bin/java             ${D}${bindir}
        ln -sf ${JDK_HOME}/bin/javac            ${D}${bindir}

Am I wrong?

Best Regards,
Vincent

2017-09-14 22:21 GMT+02:00 Fabio Berton <fabio.berton at ossystems.com.br>:
> From: Jan Remmet <j.remmet at phytec.de>
>
> if bindir directory doesn't exists the link is created wrongly:
>
> file -b tmp/work/x86_64-linux/oracle-jse-jdk-x86-64-native/1.8.0-u131r0/image/home/yocto/build/tmp/sysroots/x86_64-linux/usr/bin
> symbolic link to
> `/home/yocto/build/tmp/sysroots/x86_64-linux/usr/lib/jvm/java-8-oracle/bin/javac'
>
> tested on morty
>
> Signed-off-by: Jan Remmet <j.remmet at phytec.de>
> Signed-off-by: Maxin B. John <maxin.john at intel.com>
> (cherry picked from commit 731d3d2cf7e7d65954991e79b9918575e06081c8)
> ---
>  recipes-devtools/oracle-java/oracle-jse-jdk.inc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/oracle-java/oracle-jse-jdk.inc b/recipes-devtools/oracle-java/oracle-jse-jdk.inc
> index 935ad9b..a7210d9 100644
> --- a/recipes-devtools/oracle-java/oracle-jse-jdk.inc
> +++ b/recipes-devtools/oracle-java/oracle-jse-jdk.inc
> @@ -12,11 +12,14 @@ JDK_JRE = "jdk"
>  require oracle-jse.inc
>
>  do_install_class-native() {
> -       install -d -m 0755                      ${D}${libdir_jvm}
> +       install -d                              ${D}${libdir_jvm}
>         cp -a ${S}/${JDK_JRE}${PV}_${PV_UPDATE} ${D}${JDK_HOME}
>
> +       install -d                              ${D}${bindir}
>         ln -sf ${JDK_HOME}/bin/java             ${D}${bindir}
>         ln -sf ${JDK_HOME}/bin/javac            ${D}${bindir}
> +
> +       install -d                              ${D}${JDK_HOME}/bin
>         ln -sf javah                            ${D}${JDK_HOME}/bin/gjavah
>         ln -sf jar                              ${D}${JDK_HOME}/bin/fastjar
>  }
> --
> 2.14.1
>
> --
> _______________________________________________
> yocto mailing list
> yocto at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto