[yocto] [PATCH] devtool: add clean command

Paul Eggleton paul.eggleton at linux.intel.com
Wed Oct 25 15:51:07 PDT 2017


Hi Josef,

Looks good, just a couple of minor tweaks to be made:

On Thursday, 26 October 2017 1:20:39 AM NZDT Josef Holzmayr wrote:
> Add an idiomatic way to devtool to clean a recipe.

It would be worth noting that this is particularly important within the eSDK 
because you can't run bitbake -c clean directly there.

> Signed-off-by: Josef Holzmayr <holzmayr at rsi-elektrotechnik.de>
> ---
>  scripts/lib/devtool/clean.py | 48 +++++++++++++++++++++++++++++++++++++++++
+++
>  1 file changed, 48 insertions(+)
>  create mode 100644 scripts/lib/devtool/clean.py
> 
> diff --git a/scripts/lib/devtool/clean.py b/scripts/lib/devtool/clean.py
> new file mode 100644
> index 0000000..30f4044
> --- /dev/null
> +++ b/scripts/lib/devtool/clean.py
> @@ -0,0 +1,48 @@
> +# Development tool - clean command plugin
> +#
> +# Copyright (C) 2014-2015 Intel Corporation
> +#               2017 R-S-I Elektrotechnik GmbH & Co. KG
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License version 2 as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with this program; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> +"""Devtool clean plugin"""
> +
> +import bb
> +from devtool import exec_build_env_command, check_workspace_recipe
> +
> +def _get_build_tasks(config):

This function should really be called "_get_clean_tasks".

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the yocto mailing list