[yocto] [meta-rockchip] [PATCH v2 2/3] recipes-multimedia: add gstreamer rockchip support

[Romain Perier]

Hello,


Le 12/04/2017 à 18:05, ayaka a écrit :
> This Gstreamer plugin provides a encoder and decoder plugin
> for Gstreamer through the Rockchip MPP library.
>
> Signed-off-by: ayaka <ayaka at soulik.info>
> ---
>  .../gstreamer/gstreamer1.0-rockchip.inc            | 40 ++++++++++++++++++++++
>  .../gstreamer/gstreamer1.0-rockchip_20170412.bb    |  9 +++++
>  .../gstreamer/gstreamer1.0-rockchip_git.bb         | 13 +++++++
>  3 files changed, 62 insertions(+)
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170412.bb
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
> new file mode 100644
> index 0000000..0bd70ab
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
> @@ -0,0 +1,40 @@
> +# Copyright (C) 2016 - 2017 Randy Li <ayaka at soulik.info>
> +# Released under the GNU GENERAL PUBLIC LICENSE Version 2
> +# (see COPYING.GPLv2 for the terms)
> +
> +require recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> +
> +DESCRIPTION = "GStreamer 1.0 plugins for Rockchip platforms"
> +
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=6d1e4aa87f6192354d3de840cf774d93"
> +DEPENDS += "gstreamer1.0-plugins-base rockchip-mpp"
> +
> +SRC_URI_remove = " \
> +    file://0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch \
I suggest to add a comment if you remove this patch (explain why)
> +"
> +
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +FILESPATH_prepend := "${THISDIR}/${PN}:"
> +
> +inherit gettext autotools pkgconfig

autotools and pkgconfig are already inherited by gstreamer1.0-plugins.inc

> +
> +PACKAGECONFIG ??= " \
> +    mpp             \
> +"
> +PACKAGECONFIG[mpp]    = "--enable-rockchipmpp,--disable-rockchipmpp,rockchip-mpp"
> +PACKAGECONFIG[vpudec] = "--enable-vpudec,--disable-vpudec,rockchip-vpu"
> +PACKAGECONFIG[drm]    = "--enable-drmrockchip,--disable-drmrockchip,libdrm-rockchip"
> +PACKAGECONFIG[egl]    = "--enable-armmali,--disable-armmali,arm-mali"
> +
> +EXTRA_OECONF += "    \
> +    --disable-kms    \

Why do you disable kms ?

> +"
> +EXTRA_OECONF_remove = "--disable-gtk-doc"
> +
> +do_configure[prefuncs] = " delete_pkg_m4_file"
comments ?
> +
> +do_configure() {
> +    NOCONFIGURE=true ${S}/autogen.sh
> +    oe_runconf
> +}
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170412.bb b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170412.bb
> new file mode 100644
> index 0000000..e3fecaf
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170412.bb
> @@ -0,0 +1,9 @@
> +# Copyright (C) 2016 - 2017 Randy Li <ayaka at soulik.info>
> +# Released under the GNU GENERAL PUBLIC LICENSE Version 2
> +# (see COPYING.GPLv2 for the terms)
> +include gstreamer1.0-rockchip.inc
> +
> +TAG = "release_${PV}"
> +SRC_URI = "git://github.com/rockchip-linux/gstreamer-rockchip.git;tag=${TAG};nobranch=1"
> +
> +S = "${WORKDIR}/git"
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
> new file mode 100644
> index 0000000..bd20121
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
> @@ -0,0 +1,13 @@
> +# Copyright (C) 2016 - 2017 Randy Li <ayaka at soulik.info>
> +# Released under the GNU GENERAL PUBLIC LICENSE Version 2
> +# (see COPYING.GPLv2 for the terms)
> +
> +DEFAULT_PREFERENCE = "-1"
What is this variable ?
> +
> +include gstreamer1.0-rockchip.inc
> +
> +SRCBRANCH ?= "develop"
> +SRCREV = "${AUTOREV}"
> +SRC_URI = "git://github.com/rockchip-linux/gstreamer-rockchip.git;branch=develop"
> +
> +S = "${WORKDIR}/git"

That's globally a good work, thanks for this, please send a v2 with
modifications, and include your real name in all patches.

Thanks,
Romain