[yocto] [PATCH V4 10/10] update_layer.py: delete layerbranch for non-existed branch
liezhi.yang at windriver.com
Thu Jun 22 03:55:15 PDT 2017
On 06/21/2017 10:31 PM, Paul Eggleton wrote:
> On Tuesday, 13 June 2017 4:36:51 AM CEST Robert Yang wrote:
>> The branch is not needed any more when it has been removed from the repo, so
>> we also need remove its layerbranch, otherwise it still can be got from the
>> web, which causes confusions.
> I think I'd previously avoided this since I was concerned we'd potentially
> lose data about a branch which was manually gathered (such as maintainer
> information) however I can't actually think of a scenario now where you would
> lose valuable data - if the branch is gone then there's not much point keeping
> a reference to it around, so this should be OK.
>> Note, we have to move the location of tinfiol's code to make it can be
>> shutdown correctly.
> How does this relate to the rest of this change? Also, can you explain the
> issue you were hitting? The try...finally is supposed to ensure it gets shut
I updated the commit message:
update_layer.py: delete layerbranch for non-existed branch
The branch is not needed any more when it has been removed from the repo, so we
also need remove its layerbranch, otherwise it still can be got from the web,
which causes confusions.
Note, we have to move the location of tinfiol's code to avoid creating tinfoil
when not needed, otherewise, if tinfoil is created (but not needed), and the
program exists earlier before "try ... finally" block, then tinfoil.shutdown()
doesn't run so that it is not shutdown. Move the code back, right before where
it is needed can fix the problem.
More information about the yocto