[yocto] [PATCH] Added missing LDFLAGS in sample recipe for morty branch

[Khem Raj]

On Sun, Jul 2, 2017 at 1:01 AM, Pierre FICHEUX <pierre.ficheux at smile.fr> wrote:
> Hi,
>
> Yes but it was fixed that way in the Pyro branch.
>
I thought this patch was being proposed for master. If yes then different
solution in pyro should not be a big problem. you can always backport
the new patch to pyro

> do_compile() {
>              ${CC} ${LDFLAGS} helloworld.c -o helloworld
> }
>
> regards
>
> --
> Pierre FICHEUX -/- CTO Smile-ECS, France -\- pierre.ficheux at smile.fr
>                                     http://www.smile.fr
>                                     http://ingenierie.openwide.fr
> I would love to change the world, but they won't give me the source code
>
>
> Le 2017-07-01 16:53, Khem Raj a écrit :
>>
>> On 7/1/17 12:52 AM, Pierre FICHEUX wrote:
>>>
>>> This problem causes the following error :
>>>
>>> ERROR: example-0.1-r0 do_package_qa: QA Issue: No GNU_HASH in the elf
>>> binary
>>>
>>> Signed-off-by: Pierre FICHEUX <pierre.ficheux at smile.fr>
>>> ---
>>>  .../target/arch/layer/recipes-example/example/example-recipe-0.1.bb    |
>>> 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb
>>> b/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb
>>> index 5fbf594..e534d36 100644
>>> ---
>>> a/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb
>>> +++
>>> b/scripts/lib/bsp/substrate/target/arch/layer/recipes-example/example/example-recipe-0.1.bb
>>> @@ -14,7 +14,7 @@ SRC_URI = "file://helloworld.c"
>>>  S = "${WORKDIR}"
>>>
>>>  do_compile() {
>>> -            ${CC} helloworld.c -o helloworld
>>> +            ${CC} ${LDFLAGS} helloworld.c -o helloworld
>>
>>
>> perhaps doing compile and link in two steps where CFLAGS and LDFLAGS are
>> used would be clearer
>>
>> something like
>>
>> ${CC} ${CFLAGS} -c helloworld.c -o helloworld.o
>> ${LD} ${LDFLAGS} helloworld.o -o helloworld
>>
>>
>>>  }
>>>
>>>  do_install() {
>>>
>