[yocto] [[PATCH][layerindex]] layerindex: Update tinfoil to call shutdown method

Paul Eggleton paul.eggleton at linux.intel.com
Wed Jan 11 11:21:08 PST 2017


On Wed, 11 Jan 2017 08:42:46 Aníbal Limón wrote:
> On 01/11/2017 02:59 AM, Paul Eggleton wrote:
> > On Thu, 05 Jan 2017 15:21:36 Aníbal Limón wrote:
> >> The new client/server API of tinfoil requires explicit call of
> >> shutdown method to send the event for finalize cooker process.
> >> 
> >> Also in update_layer remove the databuilder and cache instance
> >> now isn't needed.
> > 
> > This patch didn't apply against master - the databuilder piece does not
> > appear to be there.
> 
> Great may be was my own changes against RRS,
> 
> Only a comment if your layerindex scripts don't call shutdown the update
> script seems blocked because never arrives the event.

On the paule/django18 branch the update_layer.py script already calls 
shutdown(), and your patch takes care of the rest.

However this seems like a bug to me - if the client neglects to call 
shutdown() it would be nice if it didn't break things. Earlier I did use a 
destructor within the Tinfoil class to call shutdown() if it hadn't already 
been called, but I don't think that's reliable.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the yocto mailing list