[yocto] [PATCH] yocto-docs: Some aesthetic changes to kernel-dev-common.xml

Hart, Darren darren.hart at intel.com
Thu Feb 23 09:44:52 PST 2017


> -----Original Message-----
> From: Robert P. J. Day [mailto:rpjday at crashcourse.ca]
> Sent: Thursday, February 23, 2017 9:40 AM
> To: Hart, Darren <darren.hart at intel.com>
> Cc: Yocto discussion list <yocto at yoctoproject.org>
> Subject: RE: [PATCH] yocto-docs: Some aesthetic changes to kernel-dev-
> common.xml
> 
> On Thu, 23 Feb 2017, Hart, Darren wrote:
> 
> > > -----Original Message-----
> > > From: Robert P. J. Day [mailto:rpjday at crashcourse.ca]
> > > Sent: Thursday, February 23, 2017 3:08 AM
> > > To: Yocto discussion list <yocto at yoctoproject.org>
> > > Cc: Hart, Darren <darren.hart at intel.com>
> > > Subject: [PATCH] yocto-docs: Some aesthetic changes to kernel-dev-
> > > common.xml
> > >
> > >
> > > Small number of aesthetic/visual changes to kernel-dev-
> common.xml.
> > >
> >
> > Erm... that's not really what these are :-) These are a mix of
> > grammatical fixes, format preferences, and clarifying commentary,
> > which do amount to some functional changes in terms of what a reader
> > may do or not do as a result of reading them. Please be explicit in
> > your commit log.
> >
> > That said, I have no objections to these changes, the majority of
> > which I consider to be good improvements. Thanks for taking the time
> > to improve the documentation.
> 
>   so i should resubmit PATCH v2 with a more detailed commit msg? ok, i
> can do that. stay tuned ...

That is ultimately up to the maintainer who could decide to update the message
themselves, or require a v2 from you. If it were me, I would just submit a v2
with an updated commit message as that is likely the fastest path to merging,
and you are sure to get your intent captured.

Thanks!
--
Darren Hart
Intel Open Source Technology Center




More information about the yocto mailing list