[yocto] [meta-rockchip][PATCH 1/3] remove DEFAULTTUNEs

Trevor Woerner twoerner at gmail.com
Fri Feb 17 10:07:46 PST 2017


The DEFAULTTUNE configuration should not be set at the BSP layer but in a
DISTRO layer (or a user's conf/local.conf). Remove the two DEFAULTTUNEs that
are currently in the layer and add a note in the README to inform users of
this issue and potential settings.

Signed-off-by: Trevor Woerner <twoerner at gmail.com>
---
 README                          | 15 +++++++++++++++
 conf/machine/include/rk3066.inc |  1 -
 conf/machine/include/rk3288.inc |  1 -
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/README b/README
index ff28887..68ff433 100644
--- a/README
+++ b/README
@@ -49,6 +49,7 @@ Table of Contents
   I. Configure yocto/oe environment
  II. Building a second level bootloader based on kexec
 III. Booting your device
+ IV. Performance
 
 I. Configure yocto/oe environment
 ========================================
@@ -127,3 +128,17 @@ Then, plug your SDCARD into your Rockchip device and power on the board. If
 everything worked fine, Petitboot should be started automatically and list all 
 entries found in the configuration file.
 
+IV. Performance
+===============
+
+By default a BSP layer should not be tuning a build, this is a DISTRO-level
+decision. As such the default machine settings are meant to be the lowest
+common denominator in order to maximize generality. If you are interested in
+tweaking your build to maximize performance you can either use a DISTRO that
+has these same goals, or you can add settings in your configuration files
+(e.g. local.conf) as follows:
+
+	for rk3288:
+		DEFAULTTUNE = "cortexa17hf-neon-vfpv4"
+	for rk3066:
+		DEFAULTTUNE = "cortexa9-neon"
diff --git a/conf/machine/include/rk3066.inc b/conf/machine/include/rk3066.inc
index d43a88c..e307074 100644
--- a/conf/machine/include/rk3066.inc
+++ b/conf/machine/include/rk3066.inc
@@ -1,7 +1,6 @@
 # Copyright (C) 2014 NEO-Technologies
 # Released under the MIT license (see COPYING.MIT for the terms)
 
-DEFAULTTUNE = "cortexa9-neon"
 require conf/machine/include/tune-cortexa9.inc
 
 PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
diff --git a/conf/machine/include/rk3288.inc b/conf/machine/include/rk3288.inc
index e6c19a2..86fc567 100644
--- a/conf/machine/include/rk3288.inc
+++ b/conf/machine/include/rk3288.inc
@@ -3,7 +3,6 @@
 
 require conf/machine/include/tune-cortexa17.inc
 
-DEFAULTTUNE="cortexa17-neon"
 PREFERRED_PROVIDER_virtual/kernel = "linux"
 SERIAL_CONSOLES = "115200;ttyS2"
 KERNEL_IMAGETYPE = "zImage"
-- 
2.11.0.258.ge05806d




More information about the yocto mailing list