[yocto] [meta-swupd][PATCH 3/3] bundles.py: fix copying of full image to full bundle when no SWUPD_BUNDLES

Patrick Ohly patrick.ohly at intel.com
Thu Feb 16 07:50:31 PST 2017


On Thu, 2017-02-16 at 16:41 +0100, Patrick Ohly wrote:
> On Thu, 2017-02-16 at 14:58 +0000, André Draszik wrote:
> > When SWUPD_BUNDLES is not set, exceptions are thrown, stopping the
> > build - there are two issues in here:
> > - the debug statement references a non-existent variable, 'bundle' was
> >   renamed to fulltar
> > - copyxattrfiles() needs a list of files as 2nd argument, not a filename
> >   of a file which contains this list
> > 
> > This got broken in commit 6c097131ad39
> > ("meta-swupd: support rm_work.bbclass") while support for rm_work
> > was being added.
> 
> I should have fixed that already in commit 
> 531a8e636 "bundles.py: fix "no bundles" special case". Can you rebase
> onto current master and retest.

Never mind, my bad. The commit you mentioned is after my fix, so in
other words, I fixed it, changed something, and broke it again. Clearly
this whole layer needs automated test cases :-/

Something to do for a maintainer with a bit more time available. There
is https://bugzilla.yoctoproject.org/show_bug.cgi?id=9783 for it, but I
don't think I'll be able to work on that anytime soon.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.






More information about the yocto mailing list