[yocto] [meta-rockchip][PATCH 2/7] machine: Add machine file for the rk3288 linux Boards

jacob-chen at iotwrt.com jacob-chen at iotwrt.com
Fri Feb 3 07:48:33 PST 2017


Hi all,

Thanks for reviewing, I will looking at comments and suggestions after 
the other work finished.

: )



在 2017年01月27日 22:37, Romain Perier 写道:
> Hey,
>
> Could you:
> - Make one patch per new machine file and not one patch for all new 
> added machine
> - Add a clear @DESCRIPTION for each board, see an example here: 
> https://git.yoctoproject.org/cgit/cgit.cgi/meta-rockchip/tree/conf/machine/firefly-rk3288.conf
> - Write a clear and an understandable commit message for your new patches
>
> @Trevor: What do you think about this rk-linux.inc ? I don't like 
> this, either its name and what it contains.
>
> That's it for now.
> Thanks for your patches
>
>
> 2017-01-19 15:04 GMT+01:00 Jacob Chen <jacob-chen at iotwrt.com 
> <mailto:jacob-chen at iotwrt.com>>:
>
>     Evb-rk3288 is the offical evaluate board, add it to help myself
>     develop.
>
>     Fennec-rk3288 and Tinker-rk3288 is rk3288 based SBCs.
>         .
>     Tinker Boards:
>     http://www.cnx-software.com/2017/01/05/asus-tinker-board-is-a-raspberry-pi-3-alternative-based-on-rockchip-rk3288-processor/
>     <http://www.cnx-software.com/2017/01/05/asus-tinker-board-is-a-raspberry-pi-3-alternative-based-on-rockchip-rk3288-processor/>
>
>     Signed-off-by: Jacob Chen <jacob-chen at rock-chips.com
>     <mailto:jacob-chen at rock-chips.com>>
>     ---
>      conf/machine/evb-rk3288.conf      | 12 ++++++++++++
>      conf/machine/fennec-rk3288.conf   | 12 ++++++++++++
>      conf/machine/include/rk-linux.inc | 20 ++++++++++++++++++++
>      conf/machine/tinker-rk3288.conf   | 13 +++++++++++++
>      4 files changed, 57 insertions(+)
>      create mode 100644 conf/machine/evb-rk3288.conf
>      create mode 100644 conf/machine/fennec-rk3288.conf
>      create mode 100644 conf/machine/include/rk-linux.inc
>      create mode 100644 conf/machine/tinker-rk3288.conf
>
>     diff --git a/conf/machine/evb-rk3288.conf
>     b/conf/machine/evb-rk3288.conf
>     new file mode 100644
>     index 0000000..88a5f78
>     --- /dev/null
>     +++ b/conf/machine/evb-rk3288.conf
>     @@ -0,0 +1,12 @@
>     +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
>     +# Released under the MIT license (see COPYING.MIT for the terms)
>     +
>     +#@TYPE: Machine
>     +#@NAME: EVB 3288
>     +
>     +include conf/machine/include/rk3288.inc
>     +include conf/machine/include/rk-linux.inc
>     +
>     +KERNEL_DEVICETREE = "rk3288-evb-act8846.dtb"
>     +
>     +UBOOT_MACHINE = "evb-rk3288_defconfig"
>     diff --git a/conf/machine/fennec-rk3288.conf
>     b/conf/machine/fennec-rk3288.conf
>     new file mode 100644
>     index 0000000..a85045f
>     --- /dev/null
>     +++ b/conf/machine/fennec-rk3288.conf
>     @@ -0,0 +1,12 @@
>     +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
>     +# Released under the MIT license (see COPYING.MIT for the terms)
>     +
>     +#@TYPE: Machine
>     +#@NAME: FENNEC RK3288
>     +
>     +include conf/machine/include/rk3288.inc
>     +include conf/machine/include/rk-linux.inc
>     +
>     +KERNEL_DEVICETREE = "rk3288-fennec.dtb"
>     +
>     +UBOOT_MACHINE = "fennec-rk3288_defconfig"
>     diff --git a/conf/machine/include/rk-linux.inc
>     b/conf/machine/include/rk-linux.inc
>     new file mode 100644
>     index 0000000..6abaa0d
>     --- /dev/null
>     +++ b/conf/machine/include/rk-linux.inc
>     @@ -0,0 +1,20 @@
>     +# Rockchip BSP default settings
>     +
>     +PREFERRED_PROVIDER_virtual/egl = "mali-userspace"
>     +PREFERRED_PROVIDER_virtual/libgles1 = "mali-userspace"
>     +PREFERRED_PROVIDER_virtual/libgles2 = "mali-userspace"
>     +PREFERRED_PROVIDER_virtual/libopencl = "mali-userspace"
>     +
>     +# Workaround: libmali.so provided by rk having no SONAME field in it
>     +# so add it to fix rdepends problems
>     +ASSUME_SHLIBS += "libEGL.so:mali-userspace"
>     +ASSUME_SHLIBS += "libGLESv1_CM.so:mali-userspace"
>     +ASSUME_SHLIBS += "libGLESv2.so:mali-userspace"
>     +ASSUME_SHLIBS += "libOpenCL.so:mali-userspace"
>     +ASSUME_SHLIBS += "libgbm.so:mali-userspace"
>     +ASSUME_SHLIBS += "libwayland-egl.so:mali-userspace"
>     +
>     +PREFERRED_PROVIDER_virtual/kernel = "linux-rockchip"
>     +PREFERRED_PROVIDER_virtual/bootloader = "u-boot-rockchip"
>     +
>     +IMAGE_CLASSES += "rockchip-next-image"
>     diff --git a/conf/machine/tinker-rk3288.conf
>     b/conf/machine/tinker-rk3288.conf
>     new file mode 100644
>     index 0000000..0464133
>     --- /dev/null
>     +++ b/conf/machine/tinker-rk3288.conf
>     @@ -0,0 +1,13 @@
>     +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
>     +# Released under the MIT license (see COPYING.MIT for the terms)
>     +
>     +#@TYPE: Machine
>     +#@NAME: Tinker RK3288
>     +#@DESCRIPTION: ASUS Tinker Board is a Raspberry Pi 3 Alternative
>     based on Rockchip RK3288 Processor.
>     +
>     +include conf/machine/include/rk3288.inc
>     +include conf/machine/include/rk-linux.inc
>     +
>     +KERNEL_DEVICETREE = "rk3288-miniarm.dtb"
>     +
>     +UBOOT_MACHINE = "miniarm-rk3288_defconfig"
>     --
>     2.7.4
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/yocto/attachments/20170203/b15ace6d/attachment.html>


More information about the yocto mailing list