[yocto] [PATCH 08/12] upgradehelper.py: clean repo only once when recipes are specified

[Robert Yang]

On 12/08/2017 09:43 AM, Robert Yang wrote:
> Hi Alexander,
> 
> Thanks for the quick reply.
> 
> On 12/07/2017 08:58 PM, Alexander Kanavin wrote:
>> On 12/07/2017 09:37 AM, Robert Yang wrote:
>>> E.g.:
>>> $ upgradehelper.py less strace bash git
>>>
>>> The commit is removed when failed, and kept when succeed, but it would be
>>> removed when next recipe runs, so only run clean_repo once can keep the commit,
>>> which is helpful for the use
>>
>> I have removed the logic that removes commits and manipulates branches 
>> altogether. AUH will always create a commit on the current branch, even if it 
>> caused a build or testimage failure, and otherwise won't touch git at all. If 
>> the user wants further repo manipulation, they can do it with an external script
> I'm not sure, the logical *without* this patch is:
> 1) Do the commit when succeed or failed.
> 2) git format-patch
> 3) Remove the commit if failed, and leave the commit there if succeed

Sorry, "remove the comit if failed" is added by this patch, and why I did this
was because:
$ auh glibc less bash gzip bzip2

All of them will be failed to upgrade if glibc fails since others depends on
glibc, so leave a failed commit in the repo would cause troubles when upgrade
multiple recipes, so we have to remove it when failed to let others can upgrade, 
and then apply the failed commit back (if -f is specified) after all of the
recipes are done.

// Robert

> 4) The succeed commit will be removed by next recipe's run. For example:
>     $ auh less git
>     While less is succeed, git is failed, and less' commit will be cleaned
>     by git's run.
> 
> What this patch does is on step 4, don't let the next recipe's run clean
> the repo, Did I miss anything other patches, please ?
> 
> // Robert
> 
>>
>> Alex
>>