[yocto] [layerindex-web][PATCH] Redirect user to correct url after editing a layer

Amanda Brindle amanda.r.brindle at intel.com
Mon Aug 14 15:50:56 PDT 2017


Before, if a user edited a layer's name, they would be redirected
to a url utilizing the old name and then receive a 404 Page not
found error. Now, the url utilizes the new name.

Signed-off-by: Amanda Brindle <amanda.r.brindle at intel.com>
---
 layerindex/views.py | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/layerindex/views.py b/layerindex/views.py
index eaeb5c3..2a25455 100644
--- a/layerindex/views.py
+++ b/layerindex/views.py
@@ -105,11 +105,6 @@ def edit_layer_view(request, template_name, branch='master', slug=None):
         layerbranch = get_object_or_404(LayerBranch, layer=layeritem, branch=branchobj)
         deplistlayers = LayerItem.objects.exclude(id=layeritem.id).order_by('name')
         returnto = request.GET.get('returnto', 'layer_item')
-        if returnto:
-            if returnto == 'layer_review':
-                return_url = reverse_lazy(returnto, args=(layeritem.name,))
-            else:
-                return_url = reverse_lazy(returnto, args=(branch, layeritem.name))
     else:
         # Submit mode
         layeritem = LayerItem()
@@ -185,6 +180,15 @@ def edit_layer_view(request, template_name, branch='master', slug=None):
                         msg.send()
                     return HttpResponseRedirect(reverse('submit_layer_thanks'))
             messages.success(request, 'Layer %s saved successfully.' % layeritem.name)
+            if slug:
+                returnto = request.GET.get('returnto', 'layer_item')
+                if returnto:
+                    if returnto == 'layer_review':
+                        return_url = reverse_lazy(returnto, args=(layeritem.name,))
+                    else:
+                        return_url = reverse_lazy(returnto, args=(branch, layeritem.name))
+
+
             if return_url:
                 return HttpResponseRedirect(return_url)
     else:
-- 
2.7.4




More information about the yocto mailing list