[yocto] Bug 11307 - sstate.bbclass tries to modify mirror files

[Christopher Larson]

On Tue, Apr 11, 2017 at 11:37 PM, Paulo Neves <ptsneves at gmail.com> wrote:

> Commit 51edde653707e7a3cd2186082458f01f32cd1996 makes a wrong
> assumption that SSTATE_MIRRORS have write permissions.
>
> A mirror is by definition outside of it's user control. In my use case
> it happens I does not have permissions to update the access time of
> the dereferenced symbolic-link file.
>
> If we had the possibility to modify the sstate-mirror we would have
> set SSTATE_DIR instead. There are 3 possible fixes:
>
> * Revert this patch. It seems tailored to a very special use case
> which breaks the definition of mirror.
> * Only touch the file if the file access time is writeable.
> * Set (yet) another option to touch SSTATE_MIRROR files.
>
> I also can imagine this raising sever performance issues if the mirror
> is used by several users at the same time. The server will need to
> update the file meta data every time
>
> This patch fixes the bug with minimal impact on the original
> functionality. Option 2
>
>
> Related to (https://bugzilla.yoctoproject.org/show_bug.cgi?id=10857)
>
> From aa8cab9660744c8d5277f8e82f10a844884aff78 Mon Sep 17 00:00:00 2001
> From: Paulo Neves <paulo.de_sousa_neves at nokia.com>
> Date: Tue, 11 Apr 2017 10:57:47 +0300
> Subject: [PATCH] Added test for write ability of sstate-mirror .siginfo
>

Thanks much for your contribution, this seems reasonable to me. That said,
the subject line needs tweaking to meet our commit message guidelines,
i.e.: sstate.bbclass: handle non-writable sstate mirror, or similar. And
the yocto bug id should go in the body, not the subject line. I realize it
probably sounds nitpicky, but maintaining commit message quality makes it
much easier to review the logs in the future. This file is also in the
oe-core layer, so the patch should ideally go to the openembedded-core
mailing list. Thanks again!

See http://openembedded.org/wiki/Commit_Patch_Message_Guidelines.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/yocto/attachments/20170417/cc26c07e/attachment.html>