[yocto] [meta-raspberrypi][PATCH] sdcard_image-rpi.bbclass: exclude IMAGEDATESTAMP from signatures of do_image_rpi_sdimg

[Jonathan Liu]

Hi Andreas/Khem,

On 13 September 2016 at 09:04, Andreas Müller
<schnitzeltony at googlemail.com> wrote:
> On Wed, Aug 17, 2016 at 6:58 AM, Khem Raj <raj.khem at gmail.com> wrote:
>> Fixes taskhash mismatch e.g.
>>
>> ERROR: core-image-minimal-1.0-r0 do_image_rpi_sdimg: Taskhash mismatch 78b2e0830a66052318e5e7ffffeba193 versus 4b9bbe5dba1b48cf5cb5ad365d991de9 for /a/builder/home/kraj/work/oe/openembedded-core/meta/recipes-core/images/core-image-minimal.bb.do_image_rpi_sdimg
>> ERROR: Taskhash mismatch 78b2e0830a66052318e5e7ffffeba193 versus 4b9bbe5dba1b48cf5cb5ad365d991de9 for /a/builder/home/kraj/work/oe/openembedded-core/meta/recipes-core/images/core-image-minimal.bb.do_image_rpi_sdimg
>>
>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>> ---
>>  classes/sdcard_image-rpi.bbclass | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/classes/sdcard_image-rpi.bbclass b/classes/sdcard_image-rpi.bbclass
>> index a04204a..62df0b3 100644
>> --- a/classes/sdcard_image-rpi.bbclass
>> +++ b/classes/sdcard_image-rpi.bbclass
>> @@ -74,6 +74,7 @@ FATPAYLOAD ?= ""
>>  IMAGEDATESTAMP = "${@time.strftime('%Y.%m.%d',time.gmtime())}"
>>  IMAGE_CMD_rpi-sdimg[vardepsexclude] += "IMAGEDATESTAMP"
>>  IMAGE_CMD_rpi-sdimg[vardepsexclude] += "DATETIME"
>> +do_image_rpi_sdimg[vardepsexclude] += "DATETIME IMAGEDATESTAMP"
>>
>>  RPI_KERNEL_VERSION := "${@get_kernelversion_file('${STAGING_KERNEL_BUILDDIR}')}"
>>
>> --
>> 2.9.3
>>
> I had this in my layer but it still fails sometimes for taskhash. I
> simply removed stamp file to avoid this error [1]. Will anybody miss
> stamp file?

Yes, vardepsexclude doesn't completely solve the issue. See
http://lists.openembedded.org/pipermail/openembedded-core/2016-September/126382.html.
I an opting to remove the use of IMAGEDATESTAMP as IMAGE_NAME already
includes date and time so the image-version-info actually has the date
twice (one without dots and one with dots between the numbers). I have
posted a patch for this.

>
> [1] https://github.com/schnitzeltony/meta-raspberrypi/commit/202a132d68ea70722a93251d39e5cb75c073aabf
>
> Andreas

Regards,
Jonathan