[yocto] [layerindex-web][PATCH 08/10] layerindex: Add collection and version to layerbranch

[Liam R. Howlett]

* Paul Eggleton <paul.eggleton at linux.intel.com> [161003 18:54]:
> On Mon, 26 Sep 2016 14:25:36 Liam R. Howlett wrote:
> > Collection and version will be pulled from the layer.conf if it exists
> > and dependencies will be resolved by first checking for layers with the
> > dependency name and then checking for collections.  It is necessary to
> > shutdown tinfoil to avoid bitbake complaining about multiple instances.
> 
> I'm not sure I understand why though, and there's not an explanation given 
> here. What you're doing as a workaround only works by chance and I suspect it 
> will break horribly when we do the tinfoil2 refactor in the next release (it's 
> not expected that you'd have datastores still around and be parsing recipes 
> when tinfoil has been shut down), so we *really* need to try to avoid shutting 
> down like this. Can you explain what you saw?


I received messages about having multiple copies of bitbake running if I
did not shut down tinfoil.  I also hit `too many files opened` in the
update.py loop.  I have since reworked this patch to pass in the tinfoil
instance to layerconfparser in this patch set.  I was almost done v2
when I received your comments.  I also noticed that I had shut down
tinfoil before it should have been shut down - in v2, I had moved my
shutdown call next to sys.exit(0).  I feel much better about the way I
handle this in v2.

> 
> Cheers,
> Paul
> 
> -- 
> 
> Paul Eggleton
> Intel Open Source Technology Centre