[yocto] [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics driver: add vc4-kms-v3d to the overlays

[Herve Jourdain]

Hi Andrei,

While I totally agree with that, the other lines above do not add the
space...
And I've been asked before to not modify the formatting - albeit that was in
a case of spaces replacing tabs, which is slightly different - which is why
I did this way.
Do you want me to do the modification only for my 2 lines, or also for the
other similar lines - while I'm at it...

Herve

-----Original Message-----
From: Andrei Gherzan [mailto:andrei at gherzan.ro] 
Sent: jeudi 19 mai 2016 16:57
To: Herve Jourdain <herve.jourdain at neuf.fr>
Cc: yocto at yoctoproject.org
Subject: Re: [yocto] [meta-raspberrypi][PATCH 2/8] Support for vc4 graphics
driver: add vc4-kms-v3d to the overlays

On Wed, May 18, 2016 at 08:21:16PM +0800, Herve Jourdain wrote:
> This patch series enables the support for the VC4 graphics driver from
Eric Anholt.
> Add vc4-kms-v3d overlay if 'vc4graphics' is in MACHINE_FEATURES.
> (This patch has a dependency on the patch that enables the support of
.dtbo overlay files)
>
> Signed-off-by: Herve Jourdain <herve.jourdain at neuf.fr>
> ---
>  recipes-bsp/bootfiles/rpi-config_git.bb | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb
b/recipes-bsp/bootfiles/rpi-config_git.bb
> index 4bc8eb7..79e436d 100644
> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
> @@ -19,6 +19,8 @@ PITFT="${@bb.utils.contains("MACHINE_FEATURES", "pitft",
"1", "0", d)}"
>  PITFT22="${@bb.utils.contains("MACHINE_FEATURES", "pitft22", "1", "0",
d)}"
>  PITFT28r="${@bb.utils.contains("MACHINE_FEATURES", "pitft28r", "1", "0",
d)}"
>
> +VC4GRAPHICS="${@bb.utils.contains("MACHINE_FEATURES", "vc4graphics", "1",
"0", d)}"
> +
>  inherit deploy
>
>  do_deploy() {
> @@ -102,6 +104,12 @@ do_deploy() {
>          echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>          echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>      fi
> +
> +    # VC4 Graphics support
> +    if [ "${VC4GRAPHICS}" = "1" ]; then
> +        echo "# Enable VC4 Graphics"
>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> +        echo "dtoverlay=vc4-kms-v3d,cma-256"
>>${DEPLOYDIR}/bcm2835-bootfiles/config.txt

NIT: space after >>

--
Andrei Gherzan