[yocto] [meta-raspberrypi][PATCH 1/6] linux-raspberrypi: Allow override of PV

[Andrei Gherzan]

On Sun, May 29, 2016 at 04:59:08PM +0100, Paul Barker wrote:
> PV is now set in each version of the linux-raspberrypi recipe instead of in
> linux-raspberrypi.inc. This allows linux-raspberrypi.inc to be used in custom
> kernel recipes in another layer which require a different PV value.
>
> Signed-off-by: Paul Barker <paul at paulbarker.me.uk>
> ---
>  recipes-kernel/linux/linux-raspberrypi.inc     | 1 -
>  recipes-kernel/linux/linux-raspberrypi_3.18.bb | 1 +
>  recipes-kernel/linux/linux-raspberrypi_4.1.bb  | 1 +
>  recipes-kernel/linux/linux-raspberrypi_4.4.bb  | 1 +
>  4 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index 4799c74..dd477cd 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -13,7 +13,6 @@ SRC_URI += " \
>  COMPATIBLE_MACHINE = "raspberrypi"
>
>  PE = "1"
> -PV = "${LINUX_VERSION}+git${SRCPV}"
>
>  # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
>  KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
> diff --git a/recipes-kernel/linux/linux-raspberrypi_3.18.bb b/recipes-kernel/linux/linux-raspberrypi_3.18.bb
> index 1110b71..b16a1d7 100644
> --- a/recipes-kernel/linux/linux-raspberrypi_3.18.bb
> +++ b/recipes-kernel/linux/linux-raspberrypi_3.18.bb
> @@ -1,6 +1,7 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>
>  LINUX_VERSION ?= "3.18.16"
> +PV = "${LINUX_VERSION}+git${SRCPV}"
>
>  SRCREV = "1bb18c8f721ef674a447f3622273f2e2de7a205c"
>  SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-3.18.y \
> diff --git a/recipes-kernel/linux/linux-raspberrypi_4.1.bb b/recipes-kernel/linux/linux-raspberrypi_4.1.bb
> index 79fac66..9e1572e 100644
> --- a/recipes-kernel/linux/linux-raspberrypi_4.1.bb
> +++ b/recipes-kernel/linux/linux-raspberrypi_4.1.bb
> @@ -1,6 +1,7 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>
>  LINUX_VERSION ?= "4.1.21"
> +PV = "${LINUX_VERSION}+git${SRCPV}"
>
>  SRCREV = "ff45bc0e8917c77461b2901e2743e6339bb70413"
>  SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.1.y \
> diff --git a/recipes-kernel/linux/linux-raspberrypi_4.4.bb b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
> index ba47b22..12bb43a 100644
> --- a/recipes-kernel/linux/linux-raspberrypi_4.4.bb
> +++ b/recipes-kernel/linux/linux-raspberrypi_4.4.bb
> @@ -1,6 +1,7 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
>
>  LINUX_VERSION ?= "4.4.9"
> +PV = "${LINUX_VERSION}+git${SRCPV}"
>
>  SRCREV = "3b440738b5c1adc3ec3ee72ceca799d1b8d264df"
>  SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.4.y \

I'm not really happy in duplicating PV. Wouldn't a weak assignment work
for you? PV ?= "${LINUX_VERSION}+git${SRCPV}" . So you can overwrite it
as you want.

--
Andrei Gherzan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.yoctoproject.org/pipermail/yocto/attachments/20160615/5e5900ca/attachment.pgp>