[yocto] [meta-raspberrypi][PATCH 4/5] pitft: Add basic support for PiTFT

[Khem Raj]

On Mon, Jan 11, 2016 at 10:51 PM, Petter Mabäcker <petter at technux.se> wrote:
> 2016-01-11 21:32 skrev Andrei Gherzan:
>
> On Mon, Jan 11, 2016 at 09:55:43AM -0800, Khem Raj wrote:
>
> On Jan 11, 2016, at 8:49 AM, Petter Mabäcker <petter at technux.se> wrote: Add
> basic support for PiTFT display by using device-trees. In order get it
> working below configurations must be active in local.conf: MACHINEOVERRIDES
> .= ":pitft”
>
> Using MACHINE_FEATURES will be more appropriate term. Effects are same.
>
> Indeed. I support MACHINE_FEATURE usage here.
>
> I agree that the term MACHINE_FEATURES is better. However since
> MACHINE_FEATURES isn't included in the OVERRIDES variable I will not be able
> to use the task pre/appends that was the reason I used MACHINEOVERRIDES in
> the first place. The reason I want to use overrides in this case is since I
> think it makes the code easier to read and understand for the user (in this
> particular case at least). I can of course change to just using variables
> (like in many other optional features in meta-raspberrypi) or change to
> MACHINE_FEATURES. But I'm not sure how I can solve for example the below
> part in a effective and nice way:

it really doesnt need to have override, you can enquire
MACHINE_FEATURES in python or shell.

>
> xserver-xf86-config_0.1.bbappend
>
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> SRC_URI_append_rpi = " file://xorg.conf.d/10-evdev.conf "
> SRC_URI_append_pitft = " file://xorg.conf.d/99-pitft.conf "
> <---------------- My change....
>
> do_install_append_rpi () {
>     install -d ${D}/${sysconfdir}/X11/xorg.conf.d/
>     install -m 0644 ${WORKDIR}/xorg.conf.d/*
> ${D}/${sysconfdir}/X11/xorg.conf.d/
> }
>
> FILES_${PN}_rpi += "${sysconfdir}/X11/xorg.conf
> ${sysconfdir}/X11/xorg.conf.d/*"
> ------------------- end -----------------------
>
>
>
> But if you have any good suggestions about how to solve this, please
> enlighten me =)
>
> BR Petter
>
> -- Andrei Gherzan