[yocto] [meta-raspberrypi][PATCH] omxplayer: fix host-user-contaminated QA warnings
Andrei Gherzan
andrei at gherzan.ro
Sat Feb 27 04:56:01 PST 2016
On Sat, Feb 27, 2016 at 12:21:08AM +1100, Jonathan Liu wrote:
> Explicitly chown the installed files to fix host-user-contaminated QA
> warnings for libavcodec, libavdevice, libavfilter, libavformat,
> libavutil and libswresample shared libraries.
>
> Signed-off-by: Jonathan Liu <net147 at gmail.com>
> ---
> recipes-multimedia/omxplayer/omxplayer_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb b/recipes-multimedia/omxplayer/omxplayer_git.bb
> index a0690a0..8816273 100644
> --- a/recipes-multimedia/omxplayer/omxplayer_git.bb
> +++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
> @@ -61,6 +61,7 @@ do_install() {
> oe_runmake STRIP='echo skipping strip' dist
> mkdir -p ${D}${datadir}/fonts/truetype/freefont/
> install ${S}/fonts/* ${D}${datadir}/fonts/truetype/freefont/
> + chown root:root -R ${D}
> }
>
> FILES_${PN} = "${bindir}/omxplayer* \
> --
> 2.7.1
>
Actually the problem here is how the package does the dist target.
Makefile:
...
<-->cp -a ffmpeg_compiled/usr/lib/*.so* $(DIST)/usr/lib/omxplayer/
...
This means that even if ran in a fackroot environment, this will preserve the
user id and other file attributes generating the warnings you pointed out.
In order to fix this I would vote for a patch that would change the archive
flag to a simple -R (-P is default anyway). What do you think?
As well this patch should go upstream too as I don't see the idea behind
copying those while preserving the file attributes.
> --
> _______________________________________________
> yocto mailing list
> yocto at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
--
Andrei Gherzan
More information about the yocto
mailing list