[yocto] [RFC] [autobuilder] Autobuilder.py: add verbose buildset parse error

Flanagan, Elizabeth elizabeth.flanagan at intel.com
Tue Feb 23 09:20:36 PST 2016


On 23 February 2016 at 15:42, Alex Franco
<alejandro.franco at linux.intel.com> wrote:
> From: Alejandro Franco <alejandro.franco at linux.intel.com>
>
> Add a more verbose Exception when a buildset parse operation fails
>

Approved and in master.

-b

> Signed-off-by: Alejandro Franco <alejandro.franco at linux.intel.com>
> ---
>  lib/python2.7/site-packages/autobuilder/Autobuilder.py | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/lib/python2.7/site-packages/autobuilder/Autobuilder.py b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> index 3174784..f200974 100644
> --- a/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> +++ b/lib/python2.7/site-packages/autobuilder/Autobuilder.py
> @@ -118,12 +118,15 @@ class Autobuilder:
>      def parseRepos(self, buildset=None):
>          buildset=buildset
>          if self.configdict[buildset].has_key('repos'):
> -            for layer in ast.literal_eval(self.configdict[buildset]['repos']):
> -                if layer.iterkeys().next() not in self.repos:
> -                    schedpropstoextend, newcheckoutprops = self.CreateLayerSchedulerParams(layer=layer, trigger=buildset, triggerer=True)
> -                    self.schedprops.extend(schedpropstoextend)
> -                    self.checkoutprops.update(newcheckoutprops)
> -                    self.repos.append(layer.iterkeys().next())
> +            try:
> +                for layer in ast.literal_eval(self.configdict[buildset]['repos']):
> +                    if layer.iterkeys().next() not in self.repos:
> +                        schedpropstoextend, newcheckoutprops = self.CreateLayerSchedulerParams(layer=layer, trigger=buildset, triggerer=True)
> +                        self.schedprops.extend(schedpropstoextend)
> +                        self.checkoutprops.update(newcheckoutprops)
> +                        self.repos.append(layer.iterkeys().next())
> +            except SyntaxError as err:
> +                raise ABConfigError("%s found in %s" % (err, buildset))
>          return
>
>      def parseProps(self, buildset):
> --
> 1.9.1
>



-- 
Elizabeth Flanagan
Yocto Project
Build and Release



More information about the yocto mailing list