[yocto] [meta-qt4][PATCH 1/2] qt4-embedded.inc: provide PACKAGECONFIG for tslib

[Maxin B. John]

Hi Martin,

On Fri, Aug 19, 2016 at 10:13:31AM +0200, Martin Jansa wrote:
> On Fri, Aug 19, 2016 at 11:01:57AM +0300, Maxin B. John wrote:
> > make tslib dependency optional
> > 
> > Signed-off-by: Maxin B. John <maxin.john at intel.com>
> > ---
> >  recipes-qt4/qt4/qt4-embedded.inc | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/recipes-qt4/qt4/qt4-embedded.inc b/recipes-qt4/qt4/qt4-embedded.inc
> > index 3f40b82..6e7cd86 100644
> > --- a/recipes-qt4/qt4/qt4-embedded.inc
> > +++ b/recipes-qt4/qt4/qt4-embedded.inc
> > @@ -2,7 +2,9 @@ SUMMARY = "Cross-platform UI toolkit and application framework (framebuffer vers
> >  DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is the embedded (framebuffer) version."
> >  SECTION = "libs"
> >  HOMEPAGE = "http://qt-project.org/"
> > -DEPENDS += "tslib"
> > +
> > +PACKAGECONFIG ??= ""
> > +PACKAGECONFIG[tslib] = "QT_EMBEDDED_EXTRA_FLAGS_append ='  -plugin-mouse-tslib', , tslib"
> 
> Does this really work? 

Yes, it was tested before.   

> Why don't you append PACKAGECONFIG_CONFARGS
> variable to QT_EMBEDDED_EXTRA_FLAGS and leave only -plugin-mouse-tslib
> in PACKAGECONFIG?

Your suggestion looks better and will try to update it based on that, Thanks.
(A quick grep in meta-qt4 for PACKAGECONFIG_CONFARGS returned zero results)

> >  QT4EDEPENDS = ""
> >  QT_BASE_LIB  ?= "libqt-embedded"
> > @@ -18,7 +20,7 @@ QT_EMBEDDED_FLAGS ?= " \
> >  "
> >  QT_EMBEDDED_EXTRA_FLAGS ?= " \
> >      -plugin-gfx-transformed -plugin-gfx-qvfb -plugin-gfx-vnc \
> > -    -plugin-mouse-tslib -qt-mouse-pc -qt-mouse-qvfb -qt-mouse-linuxinput \
> > +    -qt-mouse-pc -qt-mouse-qvfb -qt-mouse-linuxinput \
> >      -qt-kbd-tty -qt-kbd-linuxinput \
> >  "
> >  QT_EMBEDDED_KEYPAD_FLAGS ?= " \
> > -- 
> > 2.4.0

Best Regards,
Maxin