[yocto] [PATCH] rmc: fix allocating buffer issue in read_file() (32 bit)

Jianxun Zhang jianxun.zhang at linux.intel.com
Tue Aug 16 16:12:14 PDT 2016


Runtime test script failed on T100TA (32 bit) machine because
read_file() function in rmc.c gets a wrong value of st_size from
the buffer returned by stat(). We include rmc header files prior
to the rest of standard header files in rmc.c, so standard data
subsequently defined could be affected by "#pragma pack(1)" in rmc
header files.

Runtime test passes on T100TA and other two boards with this change.

Signed-off-by: Jianxun Zhang <jianxun.zhang at linux.intel.com>
---
 src/rmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/rmc.c b/src/rmc.c
index 714ae3a..6cf584e 100644
--- a/src/rmc.c
+++ b/src/rmc.c
@@ -10,8 +10,6 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <ctype.h>
-#include <rmcl.h>
-#include <rsmp.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
@@ -20,6 +18,8 @@
 #include <sys/stat.h>
 #include <sys/mman.h>
 
+#include <rmcl.h>
+#include <rsmp.h>
 
 #define USAGE "RMC (Runtime Machine configuration) Tool\n" \
     "NOTE: Most of usages require root permission (sudo)\n" \
-- 
2.7.4




More information about the yocto mailing list