[yocto] [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9

Paul Eggleton paul.eggleton at linux.intel.com
Tue Apr 26 19:51:54 PDT 2016


Hi Piotr,

On Fri, 22 Apr 2016 08:22:45 piotr.lewicki wrote:
> I'm new here and I didn't know how to prepare patch correctly- I just
> used instructions from meta-raspberrypi README.
> 
> I can resend it if you want. Especially now when the patch is not
> necessary anymore, because Andrei Gherzan has merged latest revision of
> omxplayer to master (patch with explicit linking vchostif lib was taken
> from there).
> 
> Please provide me with instruction on how to create a patch properly.

There are a couple of git command lines in the meta-raspberrypi README which 
if used will add Signed-off-by and the proper "[meta-raspberrypi]" subject 
prefix. Also, the shortlog (the first line of the commit message which ends up 
as the rest of the email subject) should start with the name of the recipe or 
item you're changing - in this case it would be omxplayer. The rest of the 
commit message after the blank line should then describe in a little more 
detail, most importantly covering why the patch is needed.

You may find this useful:

  http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

I know all of this seems a little onerous to begin with, but it not only makes 
patch review a bit easier for us, it also helps us keep the commit history 
readable in the (likely) event that someone wants to look back later on and 
find out why a particular change was made.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the yocto mailing list